Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call net info refresh on each reachability check #43090

Merged
merged 3 commits into from
Jun 7, 2024
Merged

fix: call net info refresh on each reachability check #43090

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37b71c1
fix: call net info refresh on each reachability check
adhorodyski Jun 5, 2024
ba755e6
chore: add a temporary server log to see the refresh happening
adhorodyski Jun 5, 2024
bd22f97
chore: run the existing recheckNetworkConnection check function
adhorodyski Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libs/NetworkConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ function subscribeToBackendAndInternetReachability(): () => void {
const intervalID = setInterval(() => {
// Offline status also implies backend unreachability
if (isOffline) {
// Periodically refresh internet reachability check
// More info: https://github.com/Expensify/App/issues/42988
NetInfo.refresh().then(() => {
adhorodyski marked this conversation as resolved.
Show resolved Hide resolved
Log.info(`[NetworkStatus] Refreshing NetInfo's network status with "isOffline" set to "true" to double-check internet reachability.`);
});
return;
}
// Using the API url ensures reachability is tested over internet
Expand Down
Loading