-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] [Search v1] Fix for workspace switcher and back to search tab on Android #43500
[CP Staging] [Search v1] Fix for workspace switcher and back to search tab on Android #43500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment
Reviewer Checklist
Screenshots/VideosScreen.Recording.2024-06-11.at.10.42.29.AM.movAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Co-authored-by: Carlos Martins <luacmartins@gmail.com>
…ch-ws [CP Staging] [Search v1] Fix for workspace switcher and back to search tab on Android (cherry picked from commit e17664e)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Details
This PR fixes following issues:
Android/Native
Android/Native
As part of this PR, the logic related to the search module has been changed: now when we change a tab on the search page, we push the central pane and the bottom tab screens into the navigation stack. Previously only central pane screen was added to the stack.
Fixed Issues
$ #43356
$ #43358
PROPOSAL:
Tests
Android - Search - Workspace switcher and Search show different selected workspace
Precondition: Account has at least two workspaces.
Android - Search - Not here page shows up when returning to Search from Account settings
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
androidBackToSearch.mov
androidWorkspaceSwitcher.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop