Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Create usePaginatedReportActions hook" #44708

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[CP Staging] Revert "Create usePaginatedReportActions hook" #44708

merged 1 commit into from
Jul 1, 2024

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg self-assigned this Jul 1, 2024
@jasperhuangg jasperhuangg changed the title Revert "Create usePaginatedReportActions hook" [CP Staging] Revert "Create usePaginatedReportActions hook" Jul 1, 2024
@jasperhuangg jasperhuangg marked this pull request as ready for review July 1, 2024 23:40
@jasperhuangg jasperhuangg requested a review from a team as a code owner July 1, 2024 23:40
@melvin-bot melvin-bot bot removed the request for review from a team July 1, 2024 23:41
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 1, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from srikarparsi July 1, 2024 23:41
@jasperhuangg
Copy link
Contributor Author

Skipping checklist since this is a straight revert in the interest of urgency

@jasperhuangg jasperhuangg merged commit 147de27 into main Jul 1, 2024
22 of 27 checks passed
@jasperhuangg jasperhuangg deleted the revert-44412-Rory-DRYReportActionsSorting branch July 1, 2024 23:41
@melvin-bot melvin-bot bot added the Emergency label Jul 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 1, 2024

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Jul 1, 2024
@jasperhuangg @OSBotify
Merge pull request #44708 from Expensify/revert-44412-Rory-DRYReportA…
08fed50 
…ctionsSorting

[CP Staging] Revert "Create usePaginatedReportActions hook"

(cherry picked from commit 147de27)
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
85 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 2, 2024

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.3-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@bernhardoj bernhardoj mentioned this pull request Jul 2, 2024
Merged
50 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 3, 2024

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

@robertjchen robertjchen robertjchen approved these changes

@srikarparsi srikarparsi Awaiting requested review from srikarparsi

Assignees

@jasperhuangg jasperhuangg

Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes when attempting to open an #admins room
4 participants
@jasperhuangg @OSBotify @robertjchen @chiragsalian