-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display optimistic fields violations for single expense reports #46425
Display optimistic fields violations for single expense reports #46425
Conversation
Note that I added optimistic field violations to |
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@allroundexperts Kind bump :) |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-05.at.4.59.45.AM.movAndroid: mWeb ChromeScreen.Recording.2024-08-05.at.4.58.42.AM.moviOS: NativeScreen.Recording.2024-08-05.at.4.57.44.AM.moviOS: mWeb SafariScreen.Recording.2024-08-05.at.4.55.50.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-05.at.4.48.02.AM.movMacOS: DesktopScreen.Recording.2024-08-05.at.4.50.55.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/libs/actions/IOU.ts
Outdated
@@ -1578,6 +1590,12 @@ function buildOnyxDataForTrackExpense( | |||
}, | |||
); | |||
|
|||
if (iouReport) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iou reports (p2p reports) shouldn't have report violations
These should be exclusive to expense reports that are on control policies. Though I can't tell if iouReport in this context means something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a comment below specifying when we should compute violations:
Line 874 in f7e265a
// We don't need to compute violations unless we're on a paid policy |
Should I move my code under this condition?
cc @thienlnam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that would be good, and if you could make sure that the paid policy is a control policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check specifically for corporate policies? We should not show these for team either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@thienlnam comment addressed :) It should be ready to be merged now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
Fixed Issues
$ #46215
$ #46223
PROPOSAL:
Tests
Report Fields
enabled (Workspaces
-> Your workspace ->More features
->Report fields
)List
type field with some initial valueList
field with default valueOffline tests
QA Steps
Report Fields
enabled (Workspaces
-> Your workspace ->More features
->Report fields
)List
type field with some initial valueList
field with default valuePR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.-.native.mov
Android: mWeb Chrome
andrioid.-.web.mov
iOS: Native
ios.-.native.mov
iOS: mWeb Safari
ios.-.web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov