-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: archived reports are unable to mark as read #46569
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@allroundexperts Do you mind if I review the PR as I'm already assigned to the linked issue? |
I can review this today @rayane-djouah. I'm a little short of issues myself and would prefer to review this instead. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-07.at.4.16.49.AM.movAndroid: mWeb ChromeScreen.Recording.2024-08-07.at.4.14.42.AM.moviOS: NativeScreen.Recording.2024-08-07.at.4.02.38.AM.moviOS: mWeb SafariScreen.Recording.2024-08-07.at.4.02.02.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-07.at.3.56.40.AM.movMacOS: DesktopScreen.Recording.2024-08-07.at.4.00.21.AM.mov |
@allroundexperts Is there any thing I can help with to move forward with the review? 🙂 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
This fixes the issue where the user is unable to mark an archived chat as read by switching to it. Issue is that we check whether the
newMessageTimeReference
is lesser than thereportAction.created
but in the case of archived reports, we havenewMessageTimeReference
equal toreportAction.created
. So the fix is to update the condition to account for equal to and also future proof of any regression by using this new condition if the report is archived.This also fixes the regression which was caused by #45240
Fixed Issues
$ #45228 #46501
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1720520521629939?thread_ts=1720290639.217409&cid=C05LX9D6E07
Tests
Steps:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov