Update archive feature #46934

cretadn22 · 2024-08-07T01:08:30Z

Details

Fixed Issues

$ #45881
PROPOSAL: #45881 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Tap fab - create a new workspace
Tap on workspace chat
Submit a expense using plus icon near compose
Navite to LHN and note green dot next to workspace chat
Tap profile icon -- workspaces -- workspace
Tap 3 dots next to workspace and delete the workspace
Navigate to LHN
Verify that archived workspace must not show green dot in LHN

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-11.at.16.21.55.mov

Android: mWeb Chrome

Screen.Recording.2024-08-11.at.16.06.46.mov

iOS: Native

Screen.Recording.2024-08-11.at.16.08.57.mov

iOS: mWeb Safari

Screen.Recording.2024-08-11.at.16.05.00.mov

MacOS: Chrome / Safari

Screen43.mp4

MacOS: Desktop

Screen44.mov

melvin-bot · 2024-08-07T01:08:35Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2024-08-07T01:32:49Z

I'm encountering some issues with the emulators. I'll upload a mobile video shortly.

situchan

are you sure that there's no more isArchivedRoom occurrences to be replaced with private_isArchived?

cretadn22 · 2024-08-09T09:10:10Z

@situchan We use this field in one more place: shouldOptionShowTooltip function

cretadn22 · 2024-08-09T09:12:16Z

I reverted the isArchivedRoom to prevent any regression. I believe it's preferable to use it this way rather than calling the isArchivedRoom function individually for each case.

cretadn22 · 2024-08-11T09:28:52Z

@situchan Could you review this PR again?

situchan · 2024-08-12T04:40:04Z

I reverted the isArchivedRoom to prevent any regression. I believe it's preferable to use it this way rather than calling the isArchivedRoom function individually for each case.

It's against what @srikarparsi said here

cretadn22 · 2024-08-13T09:50:17Z

@situchan Pushed new commit. shouldOptionShowTooltip is used elsewhere, but in those instances, option.isArchivedRoom is null, so we don't need to be concerned about those cases.

cretadn22 · 2024-08-22T04:04:20Z

@situchan Could you review this PR again?

situchan · 2024-08-22T04:42:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

src/libs/SidebarUtils.ts

situchan · 2024-08-22T07:52:10Z

src/libs/ReportUtils.ts

+    private_isArchived?: string | null;
    isIOUReportOwner?: boolean | null;
    isArchivedRoom?: boolean | null;


@srikarparsi is it fine to keep both (private_isArchived, isArchivedRoom) in OptionData?

@srikarparsi Could you give your opinion?

Sorry, didn't see this. Please correct me if I'm wrong but OptionData includes all the attributes from Report right (which already has private_isArchived)? So do we need to declare this twice?

@srikarparsi Right, I updated

cretadn22 · 2024-09-06T12:05:49Z

@situchan Please continue

srikarparsi · 2024-09-10T05:38:55Z

Hi @situchan, do you think you could take another look at this when you have a chance?

situchan · 2024-09-10T21:09:05Z

(Not related but worth mentioning)

App crashes after deleting workspace from workspaces list:

situchan

Looks good.
Hope we haven't missed anything!

srikarparsi · 2024-09-13T07:36:35Z

I think we should update to use option.private_isArchived directly. When we do migrate, this will be a one time change which should be okay but the code will be cleaner in the long run.

My thinking is that the entire point of the report/option data is to have all the fields so that we don't have to get them using the reportID.

cretadn22 · 2024-09-13T15:42:22Z

@srikarparsi Updated. Please review again.

srikarparsi · 2024-09-16T00:08:31Z

Yup, this looks great. @situchan do you think you could help with another review and we can merge?

situchan

Looks good except redundant optional chainings

src/libs/OptionsListUtils.ts

src/libs/SidebarUtils.ts

srikarparsi · 2024-09-16T21:53:57Z

Hi @cretadn22, can you please take a look at these comments when you get a chance and we can merge?

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

cretadn22 · 2024-09-17T02:10:46Z

We recently introduced a new workflow in the GitHub action (created by @blazejkustra in #49165), which has caused a failure in the GitHub action for my PR. This failure existed before and my PR makes changes to these files, causing the GitHub action to run again. Should I address this issue in my PR, or will @blazejkustra handle it elsewhere?

blazejkustra · 2024-09-17T06:50:59Z

Check this message on slack:

The intention and expectation that generally you should fix these errors, even if you didn't introduce the usage.

srikarparsi · 2024-09-17T07:26:40Z

Thanks for bringing this up, I think it would be better to keep the scope of this PR small so that we can better regression test so I created a follow up PR here to address the lint changes. I saw that we did the same thing here so I'm going to go ahead and merge this.

srikarparsi

Thanks for the changes @cretadn22 and @situchan!

melvin-bot · 2024-09-17T07:28:33Z

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

srikarparsi · 2024-09-17T07:28:51Z

Removing the emergency changes as the lint will be fixed in this follow up PR. More information in this comment

OSBotify · 2024-09-17T07:38:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-17T20:51:21Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:32:54Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update archive feature

4d3087b

cretadn22 requested a review from a team as a code owner August 7, 2024 01:08

melvin-bot bot requested a review from situchan August 7, 2024 01:08

melvin-bot bot removed the request for review from a team August 7, 2024 01:08

address lint error

8eccb7b

situchan reviewed Aug 8, 2024

View reviewed changes

update the latest main

11516db

cretadn22 force-pushed the update-archive-feature branch from 26e0ad6 to 11516db Compare August 13, 2024 09:06

apply the new update

cc7564e

situchan reviewed Aug 22, 2024

View reviewed changes

src/libs/SidebarUtils.ts Show resolved Hide resolved

cretadn22 added 2 commits August 22, 2024 14:46

update latest main

adbe9fb

add type

bde5ae2

situchan reviewed Aug 22, 2024

View reviewed changes

cretadn22 added 3 commits August 22, 2024 14:52

disable naming convention

c357161

remopve dupe

9d9ee77

merge main

4f03f7f

situchan approved these changes Sep 10, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi September 10, 2024 21:24

cretadn22 added 4 commits September 13, 2024 21:46

using private_isArchived directly

eb1cccf

update

6ef653a

update

4686350

fix test

5b741a5

situchan reviewed Sep 16, 2024

View reviewed changes

cretadn22 and others added 7 commits September 17, 2024 08:32

Update src/libs/OptionsListUtils.ts

8ebc86d

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/SidebarUtils.ts

e7aadc2

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/OptionsListUtils.ts

85593ad

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/OptionsListUtils.ts

efbad6f

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/OptionsListUtils.ts

18ab3c1

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/OptionsListUtils.ts

ae281b6

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

Update src/libs/OptionsListUtils.ts

96c5cd2

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

srikarparsi approved these changes Sep 17, 2024

View reviewed changes

srikarparsi merged commit 14b99ca into Expensify:main Sep 17, 2024
16 of 17 checks passed

melvin-bot bot added the Emergency label Sep 17, 2024

srikarparsi removed the Emergency label Sep 17, 2024

github-actions bot mentioned this pull request Sep 17, 2024

Deploy Checklist: New Expensify 2024-09-17 #49356

Closed

40 tasks

srikarparsi mentioned this pull request Sep 18, 2024

Fix ReportUtils Lint #49325

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update archive feature #46934

Update archive feature #46934

cretadn22 commented Aug 7, 2024 •

edited

Loading

melvin-bot bot commented Aug 7, 2024

cretadn22 commented Aug 7, 2024

situchan left a comment •

edited

Loading

cretadn22 commented Aug 9, 2024

cretadn22 commented Aug 9, 2024

cretadn22 commented Aug 11, 2024

situchan commented Aug 12, 2024

cretadn22 commented Aug 13, 2024

cretadn22 commented Aug 22, 2024

situchan commented Aug 22, 2024 •

edited

Loading

situchan Aug 22, 2024

cretadn22 Aug 26, 2024

cretadn22 Sep 4, 2024

srikarparsi Sep 4, 2024

cretadn22 Sep 6, 2024

cretadn22 commented Sep 6, 2024

srikarparsi commented Sep 10, 2024

situchan commented Sep 10, 2024

situchan left a comment

srikarparsi commented Sep 13, 2024

cretadn22 commented Sep 13, 2024

srikarparsi commented Sep 16, 2024

situchan left a comment

srikarparsi commented Sep 16, 2024

cretadn22 commented Sep 17, 2024 •

edited

Loading

blazejkustra commented Sep 17, 2024

srikarparsi commented Sep 17, 2024

srikarparsi left a comment

melvin-bot bot commented Sep 17, 2024

srikarparsi commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

Update archive feature #46934

Update archive feature #46934

Conversation

cretadn22 commented Aug 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 7, 2024

cretadn22 commented Aug 7, 2024

situchan left a comment • edited Loading

Choose a reason for hiding this comment

cretadn22 commented Aug 9, 2024

cretadn22 commented Aug 9, 2024

cretadn22 commented Aug 11, 2024

situchan commented Aug 12, 2024

cretadn22 commented Aug 13, 2024

cretadn22 commented Aug 22, 2024

situchan commented Aug 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan Aug 22, 2024

Choose a reason for hiding this comment

cretadn22 Aug 26, 2024

Choose a reason for hiding this comment

cretadn22 Sep 4, 2024

Choose a reason for hiding this comment

srikarparsi Sep 4, 2024

Choose a reason for hiding this comment

cretadn22 Sep 6, 2024

Choose a reason for hiding this comment

cretadn22 commented Sep 6, 2024

srikarparsi commented Sep 10, 2024

situchan commented Sep 10, 2024

situchan left a comment

Choose a reason for hiding this comment

srikarparsi commented Sep 13, 2024

cretadn22 commented Sep 13, 2024

srikarparsi commented Sep 16, 2024

situchan left a comment

Choose a reason for hiding this comment

srikarparsi commented Sep 16, 2024

cretadn22 commented Sep 17, 2024 • edited Loading

blazejkustra commented Sep 17, 2024

srikarparsi commented Sep 17, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 17, 2024

srikarparsi commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

cretadn22 commented Aug 7, 2024 •

edited

Loading

situchan left a comment •

edited

Loading

situchan commented Aug 22, 2024 •

edited

Loading

cretadn22 commented Sep 17, 2024 •

edited

Loading