-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: button doesn’t work after using 3DS flow to add GBP payment card #46936
Conversation
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@blimpich in order to test this, I assume that you will need to send me your BE env? |
Let me now when you're available so we can test it |
Sorry @hungvu193, been fighting a cold. Will message you my ngrok credentials right now. |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2024-08-29.at.00.20.30.moviOS: NativeiOS: mWeb SafariScreen.Recording.2024-08-29.at.00.16.39.movMacOS: Chrome / SafariScreen.Recording.2024-08-29.at.00.10.44.movMacOS: DesktopScreen.Recording.2024-08-29.at.00.12.44.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well! All yours @blimpich
We did not find an internal engineer to review this PR, trying to assign a random engineer to #46146 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.26-1 🚀
|
@blimpich What does 3DS flow mean? |
@kavimuru 3DS is the flow we enter when a user enters a credit card that requires Strong Customer Authentication. Basically its an extra authentication step. I don't think applause has the ability to test this because right now only people with access to an Expensify engineer's backend can test this without a real UK-based credit card. So we can skip this for no for QA. |
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
Fixed Issues
$ #46146
PROPOSAL: #46146 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android-mweb.mov
iOS: Native
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web-resize.mp4
MacOS: Desktop
desktop-resize.mp4