-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update CONTRIBUTING.md to link to working link list on Upwork #47102
Conversation
Update link to list of jobs on Upwork
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that important, but seems fine.
No testing needed, just pasting this to pass the check. Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
This PR updates the link to the Upwork issues in
Contributing.md
, to link to an actual working page!Details
The old link here went to a broken page. (Attached screenshot here). This one goes to a working page with the same search queries!
Fixed Issues
Not an actual issue that I've seen in the Github issues - just found it on my own. (Not expecting $$ for this -- just a little tweak!)
Tests
Navigate to the readme for Contributing.md
(Make sure you're logged in with any Upwork account in the same browser)
Click on the link for the Upwork job list under the
Finding a job that Expensify posted
subcategory. Compare the old link and the new one!Old one:
New one:
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop