Create status bar

[luacmartins]

Details

Adds new data types to the LHN and creates the new status bar.

Fixed Issues

$ #46585
$ #46582
$ #47101

Tests

1. Navigate to the Search page
2. Click through the different data types in the LHN
3. Click through the different status types in the Search status bar
4. Verify that the search results are updated accordingly

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I verified that similar component doesn't exist in the codebase
• I verified that all props are defined accurately and each prop has a /** comment above it */
• I verified that each file is named correctly
• I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
• I verified that the only data being stored in component state is data necessary for rendering and nothing else
• In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
• For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
• I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
• I verified that all JSX used for rendering exists in the render method
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web-sm.mov

MacOS: Desktop

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

@Expensify/design I kicked off an adhoc build, could you take this one for a spin? There are a few things to note:

1. Some of the data return will be incorrect/might not work at all until the API PR is merged
2. I noticed some funkiness on the scroll of the filters when the empty view blocks it. You can see it below.

Screen.Recording.2024-08-12.at.1.35.03.PM.mov

I'll address that tomorrow. In the meantime, could you please take a look at any other style changes we should make?

[shawnborton]

For iOS, I think it would be nice if the tabs didn't have the 20px of padding on the right. They should cut off right with the edge of the device. Here is what I see in the PR:

And here is our mocks:

[luacmartins]

I'm not a fan of that haha looks kinda broken to my eyes. Anyways, what should it look like when the user scrolls all the way, do we padding to the left?

No right padding:

Option 1: with left padding

Option 2: no left padding

[dubielzyk-expensify]

Definitely Option 2 👍

[shawnborton]

Yup, agree with that!

[luacmartins]

Cool, updated!

[shawnborton]

Nice, I can kick off a new build for testing

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/47181/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/47181/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/47181/NewExpensify.dmg	https://47181.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Looks pretty good! Here is what I found in testing...

When you select the "Paid" tab, the page reloads and the tabs are scrolled all the way to the left, and thus you can't see the active "Paid" tab:

RPReplay_Final1723822957.MP4

Also, kinda of unrelated to this PR but I realize the font size between the main "Expenses" button and the tabs are different. I think the tabs are using the right size because we use 13px size for 40px buttons. But the Expenses button is using 15px font yet the button size is only 40px tall. So I think we might consider making the Expenses button a large button which is 52px tall, and thus uses 15px font. Or we need to reduce the font size (and maybe icon size) there. Thoughts @Expensify/design

[dannymcclain]

Also, kinda of unrelated to this PR but I realize the font size between the main "Expenses" button and the tabs are different. I think the tabs are using the right size because we use 13px size for 40px buttons. But the Expenses button is using 15px font yet the button size is only 40px tall.

@shawnborton in Figma we have the appropriate size icon & text for the Expenses button. I think we should just update the text and icon size here to match what we designed in Figma: 40px tall button, 16x16px icon, 13px text size.

[shawnborton]

Big fan of that. @luacmartins let us know if you wanna handle that here or if we should make a follow up.

[arosiclair]

LGTM 👍

[arosiclair]

@luacmartins leaving it to you to address the design comments

[luacmartins]

This PR is getting big, so I'll address the scroll and fontSize issues in a follow up.

[luacmartins]

Created an issue here

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.22-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[luacmartins]

I'll revert this PR since it caused a few blockers. I'll then work on it again and on fixes for the issues.

[OSBotify]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅