-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen. #47370
Merged
jasperhuangg
merged 22 commits into
Expensify:main
from
Krishna2323:krishna2323/issue/47100
Oct 15, 2024
Merged
fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen. #47370
Changes from 8 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
cbc9815
fix: [P2P Distance] Split - Participants amount displayed 0.00 briefl…
Krishna2323 0d5d809
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 377be13
minor fixes.
Krishna2323 932a839
minor update.
Krishna2323 99f37b3
remove extra dependency.
Krishna2323 5e894bd
add suggested changes.
Krishna2323 30e13cc
define type for mileageRate.
Krishna2323 e9992b9
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 b343447
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 1d7dab0
remove redundant code.
Krishna2323 be91889
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 b2fcb63
revert useEffect to update the amount.
Krishna2323 fc1fe00
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 82e288d
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 f7e386d
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 b5293d1
move the logic to update amount for split in IOURequestStepDistance.
Krishna2323 35af9ce
fix: empty participants issue.
Krishna2323 98ca6ac
remove console log.
Krishna2323 3caf979
fix: lint issues.
Krishna2323 2558819
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 dfad015
Merge branch 'Expensify:main' into krishna2323/issue/47100
Krishna2323 22ada28
minor updates.
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have to remove the similar logic from IOURequestStepConfirmation page after we added it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parasharrajat, yeah you are right. I was looking at the wrong code and thought that it should be there to avoid regressions but we have a similar logic which only runs once when the
IOURequestStepConfirmation
mounts.I have removed the code on
IOURequestStepConfirmation
page, please check and let me know. Thanks