-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Multiline Text
though clipped can be scrolled into view
#47532
Conversation
Text
though clipped can be scrolled into view
Text
though clipped can be scrolled into viewText
though clipped can be scrolled into view
Reviewer Checklist
Screenshots/VideosAndroid: mWeb Chromemweb-chrome.moviOS: mWeb Safarimweb-safari.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks, finally!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.23-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀
|
Details
On mobile Web, multiline
Text
's clipped part can be scrolled into view by dragging selection cursor. This PR blocks scrolling entirely, through any mechanism, over overflown text.Fixed Issues
$ #27174
PROPOSAL: #27174 (comment)
Tests
Offline tests
NA
QA Steps
See Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
video_2024-08-16_13-34-26.mp4
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-08-16.at.13.35.13.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-16.at.13.28.42.mov
MacOS: Desktop