-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chat get marked as read when opened from a notification #47801
Fix chat get marked as read when opened from a notification #47801
Conversation
This comment has been minimized.
This comment has been minimized.
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.mp4Android: mWeb Chromeweb-android.moviOS: Native2024-08-28.15.08.25.moviOS: mWeb Safariweb-ios.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@rezkiy37 |
…/46235-mark-as-read-notifs
@ZhenjaHorbach done 🙂 |
Thank you ! |
@mountiny @Beamanator |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Crap |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Double sad 😢 But on the other hand |
@ZhenjaHorbach, you can test this locally - https://github.com/Expensify/App?tab=readme-ov-file#receiving-notifications. I don't understand why it could not build native platforms. Do we have some problems with |
…/46235-mark-as-read-notifs
I've synced the branch up. |
I know |
I believe they are failing now due to fastlane |
LGTM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.26-1 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
The PR fixes the leverage of the visibility variable.
Fixed Issues
$ #46235
PROPOSAL: #46235 (comment)
Tests
Offline tests
Same as "Test".
QA Steps
Same as "Test".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
Android.Chrome.mp4
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS.Safari.mp4
MacOS: Chrome / Safari
Chrome.mp4
MacOS: Desktop
Desktop.mp4