Replace Enable your wallet with Add personal bank account task #48182

nyomanjyotisa · 2024-08-28T14:41:11Z

Details

Reimplement the previous PR since it was reverted due to need to update the backend first

Fixed Issues

$ #46231
PROPOSAL: #46231 (comment)

Tests

Login with new account
Choose 'Get paid back by my employer or 'Chat and split bills with' on onboarding
Enter your name
Verify that 'Add personal bank account' task exist in Concierge chat

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-28T14:41:17Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2024-08-29T08:37:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mollfpr

LGTM 🚀

@nyomanjyotisa Just a reminder, you should add screenshots/recordings for all platform 👍

Also, I think we can add one more step case where it's verify that user can complete the task.

tgolen · 2024-08-29T13:41:20Z

Also, I think we can add one more step case where it's verify that user can complete the task.

I wasn't sure, but did this get addressed?

mollfpr · 2024-08-29T15:02:29Z

Not really, but thought would be a good idea to make sure the task is working.

tgolen · 2024-08-29T15:39:10Z

OK, I'll hold on merging this until that's added to the tests. I wasn't sure if the last step Verify that 'Add personal bank account' task exist in Concierge chat was enough to verify if the task is working or not.

tgolen · 2024-08-30T14:12:13Z

bump @nyomanjyotisa ^

tgolen · 2024-09-02T13:48:47Z

@nyomanjyotisa Can you please add the requested test to the PR description?

nyomanjyotisa · 2024-09-02T15:54:20Z

The auto mark as complete for addBankAccount task not working yet. I think we need another BE update

Currently the response from AddPersonalBankAccount API just only this:

{
    "jsonCode": 200,
    "requestID": "8bce3b7da8d86d00-CGK",
    "onyxData": [
        {
            "key": "bankAccountList",
            "onyxMethod": "merge",
            "value": {
                "5972094": {
                    "accountData": {
                        "accountNumber": "XXXXXXXXXXXX1111",
                        "additionalData": {
                            "acceptTerms": true,
                            "bankName": "",
                            "country": "US",
                            "currency": "USD",
                            "fieldsType": "local",
                            "plaidAccessToken": "",
                            "plaidAccountID": "DPxBEkDPaPSX3b5azBZkUeNekN4vBKs3RENNM",
                            "previousState": 2
                        },
                        "addressName": "Plaid Saving",
                        "allowDebit": false,
                        "bankAccountID": 5972094,
                        "created": "2024-09-02 14:32:22",
                        "defaultCredit": true,
                        "expensifyCardDomain": "",
                        "isExpensifyCardSettlementAccount": false,
                        "isSavings": true,
                        "processor": "bancorp",
                        "riskChecked": false,
                        "routingNumber": "011401533",
                        "sharees": [],
                        "state": "OPEN",
                        "type": "PERSONAL"
                    },
                    "accountType": "bankAccount",
                    "description": "Account ending in 1111",
                    "isDefault": true,
                    "key": "bankAccount-5972094",
                    "methodID": 5972094,
                    "title": "Plaid Saving"
                }
            }
        }
    ],
    "previousUpdateID": 1541025364,
    "lastUpdateID": 1541030326
}

While to auto mark the task as complete we need another onyx data from the API response. Like for the submitExpense task, RequestMoney API response have the following onyx data to mark the task as complete

       {
           "key": "reportActions_804886205397194",
           "onyxMethod": "merge",
           "value": {
               "6791102980858542433": {
                   "childCommenterCount": 0,
                   "childLastActorAccountID": null,
                   "childLastMoneyRequestComment": null,
                   "childLastReceiptTransactionIDs": null,
                   "childLastVisibleActionCreated": "",
                   "childMoneyRequestCount": null,
                   "childOldestFourAccountIDs": "",
                   "childRecentReceiptTransactionIDs": null,
                   "childReportName": "Submit an expense",
                   "childReportNotificationPreference": "hidden",
                   "childStateNum": 2,
                   "childStatusNum": 3,
                   "childType": "task",
                   "childVisibleActionCount": 0
               }
           }
       },

tgolen · 2024-09-03T14:16:22Z

When I did the backend update to allow for this task, I really just renamed the previous task so I don't know where this additional data would be coming from. Was the additional data being returned from the server for the enabled wallet task?

cc @francoisl in case you might know.

francoisl · 2024-09-03T18:26:35Z

Ah yeah, one implication of renaming the setup task that we didn't consider is that it should also auto-complete when you add a bank account. At the moment we only complete the task when you enable your Expensify wallet (because that's what the task was about). Sounds like we'd just need to also add this line in the command CreateBankAcount.

tgolen · 2024-09-04T14:42:48Z

OK, thanks @francoisl. I'll createa a PR for that today.

tgolen · 2024-09-05T16:55:47Z

The BE PR has been merged. It should deploy today. I'll post another comment when I see it get deployed.

tgolen · 2024-09-06T14:17:17Z

OK, the BE PR was deployed. @nyomanjyotisa Can you please give it another try?

nyomanjyotisa · 2024-09-07T01:05:28Z

@tgolen - The auto mark as complete for addBankAccount task is still not working. The AddPersonalBankAccount response still the same:

{
    "jsonCode": 200,
    "requestID": "8bf2a6afbb5d4ad7-CGK",
    "onyxData": [
        {
            "key": "bankAccountList",
            "onyxMethod": "merge",
            "value": {
                "6009526": {
                    "accountData": {
                        "accountNumber": "XXXXXXXXXXXX1111",
                        "additionalData": {
                            "acceptTerms": true,
                            "bankName": "",
                            "country": "US",
                            "currency": "USD",
                            "fieldsType": "local",
                            "plaidAccessToken": "",
                            "plaidAccountID": "G1JKNMZ31dTAdKvq5aZeSPyX1kGEkxc6xDMzl"
                        },
                        "addressName": "Plaid Saving",
                        "allowDebit": false,
                        "bankAccountID": 6009526,
                        "created": "2024-09-07 00:41:05",
                        "defaultCredit": true,
                        "expensifyCardDomain": "",
                        "isExpensifyCardSettlementAccount": false,
                        "isSavings": true,
                        "processor": "bancorp",
                        "riskChecked": false,
                        "routingNumber": "011401533",
                        "sharees": [],
                        "state": "OPEN",
                        "type": "PERSONAL"
                    },
                    "accountType": "bankAccount",
                    "description": "Account ending in 1111",
                    "isDefault": true,
                    "key": "bankAccount-6009526",
                    "methodID": 6009526,
                    "title": "Plaid Saving"
                }
            }
        }
    ],
    "previousUpdateID": 1681297661,
    "lastUpdateID": 1681306917
}

Here I attached a video of the test

New-Expensify.mp4

tgolen · 2024-09-09T14:27:25Z

OK, thank you. I will attempt to test it locally to ensure it is working.

francoisl · 2024-09-09T23:28:09Z

Discussed with @tgolen, going to take over while he's OOO.

Looks like there's a conflict at the moment, @nyomanjyotisa can you take a look please?

nyomanjyotisa · 2024-09-10T09:17:21Z

@francoisl - Conflict resolved

francoisl · 2024-09-10T17:37:04Z

Thanks, I'll give it a try today and see if anything is wrong in the backend still.

francoisl · 2024-09-16T23:06:58Z

I found the backend issue for the task completion and submitted a fix. I think we can go ahead and merge this now, this PR is unrelated to how the backend marks the task as completed.

OSBotify · 2024-09-16T23:18:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-17T20:51:33Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:33:08Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Replace Enable your wallet with Add personal bank account task

c4fdf8d

nyomanjyotisa requested a review from a team as a code owner August 28, 2024 14:41

melvin-bot bot requested review from mollfpr and removed request for a team August 28, 2024 14:41

nyomanjyotisa mentioned this pull request Aug 28, 2024

[Guided Setup] [$250] Replace Enable your wallet with Add personal bank account task during onboarding #46231

Closed

mollfpr approved these changes Aug 29, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen August 29, 2024 08:53

tgolen previously approved these changes Aug 29, 2024

View reviewed changes

francoisl self-requested a review September 9, 2024 23:27

Merge branch 'main' into issue-46231-2

ef9a715

nyomanjyotisa dismissed tgolen’s stale review via ef9a715 September 10, 2024 07:42

francoisl approved these changes Sep 16, 2024

View reviewed changes

francoisl merged commit 2af5a95 into Expensify:main Sep 16, 2024
17 checks passed

github-actions bot mentioned this pull request Sep 17, 2024

Deploy Checklist: New Expensify 2024-09-17 #49356

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Enable your wallet with Add personal bank account task #48182

Replace Enable your wallet with Add personal bank account task #48182

nyomanjyotisa commented Aug 28, 2024 •

edited

Loading

melvin-bot bot commented Aug 28, 2024

mollfpr commented Aug 29, 2024 •

edited

Loading

mollfpr left a comment

tgolen commented Aug 29, 2024

mollfpr commented Aug 29, 2024

tgolen commented Aug 29, 2024

tgolen commented Aug 30, 2024

tgolen commented Sep 2, 2024

nyomanjyotisa commented Sep 2, 2024

tgolen commented Sep 3, 2024

francoisl commented Sep 3, 2024

tgolen commented Sep 4, 2024

tgolen commented Sep 5, 2024

tgolen commented Sep 6, 2024

nyomanjyotisa commented Sep 7, 2024

tgolen commented Sep 9, 2024

francoisl commented Sep 9, 2024

nyomanjyotisa commented Sep 10, 2024

francoisl commented Sep 10, 2024

francoisl commented Sep 16, 2024

OSBotify commented Sep 16, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

Replace Enable your wallet with Add personal bank account task #48182

Replace Enable your wallet with Add personal bank account task #48182

Conversation

nyomanjyotisa commented Aug 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 28, 2024

mollfpr commented Aug 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

tgolen commented Aug 29, 2024

mollfpr commented Aug 29, 2024

tgolen commented Aug 29, 2024

tgolen commented Aug 30, 2024

tgolen commented Sep 2, 2024

nyomanjyotisa commented Sep 2, 2024

tgolen commented Sep 3, 2024

francoisl commented Sep 3, 2024

tgolen commented Sep 4, 2024

tgolen commented Sep 5, 2024

tgolen commented Sep 6, 2024

nyomanjyotisa commented Sep 7, 2024

tgolen commented Sep 9, 2024

francoisl commented Sep 9, 2024

nyomanjyotisa commented Sep 10, 2024

francoisl commented Sep 10, 2024

francoisl commented Sep 16, 2024

OSBotify commented Sep 16, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

nyomanjyotisa commented Aug 28, 2024 •

edited

Loading

mollfpr commented Aug 29, 2024 •

edited

Loading