-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258
Merged
luacmartins
merged 46 commits into
Expensify:main
from
software-mansion-labs:@szymczak/search-bar-hiding
Sep 30, 2024
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
0cdffe1
add animation logic
SzymczakJ ce6f1cc
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 6ea15d8
prettify code
SzymczakJ ec1402b
adjust padding
SzymczakJ c2cb62e
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ e93ceca
make SearchPageHeader use SearchContext instead of accepting data param
SzymczakJ 1e5ff51
move modals from Search/index to SearchPageHeader
SzymczakJ cd01f44
fix paddings
SzymczakJ ce7d213
fix EmptyState and Loading screen paddings
SzymczakJ 709e93d
fix loading state bug
SzymczakJ 317cc9e
fix PR comments
SzymczakJ 8fd252b
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 8794f8c
fix typo in comment
SzymczakJ 261df38
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ c59ff2f
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ c0866fa
fix PR comments
SzymczakJ ce2a6d3
remove getReportsFromSelectedTransactions from SearchUtils
SzymczakJ db5812c
fix
SzymczakJ b0bf4c0
fix lint
SzymczakJ 217ebf3
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 552e596
merge main
SzymczakJ 1218079
modify scroll speed
SzymczakJ c85e65f
fix animation
SzymczakJ a7cc0e4
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 28f7efe
clean up code
SzymczakJ b5ce7cd
fix pr comments
SzymczakJ 060ea0d
fix pr comments
SzymczakJ 888db7d
fix animation
SzymczakJ e222001
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ bb7fb4d
fix linter
SzymczakJ a51f7db
fix empty state not showing
SzymczakJ 8319d34
clean up code
SzymczakJ 9b7e621
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 487945d
clean up code
SzymczakJ 7146a1d
fix styles
SzymczakJ 91e44d4
fix PR comments
SzymczakJ 0a672cf
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 786c2cb
fix PR comments
SzymczakJ 3d556e4
fix modal not showing bug
SzymczakJ 009d3d3
fix PR comments
SzymczakJ 3fd8995
fix margin
SzymczakJ 557625b
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 89f95be
fix PR comments
SzymczakJ c507ca1
fix styles
SzymczakJ ca27414
Merge branch 'main' into @szymczak/search-bar-hiding
SzymczakJ 029f277
fix styles
SzymczakJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug on small screens: Selected multiple expenses and clicked "delete," but the delete confirmation modal did not appear.
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-19.at.23.02.42.mp4