Add inline images preview to the Live Markdown Input on the web

[Skalakid]

Details

This PR bumps the version of the react-native-live-markdown to the latest and enables the inline image previews inside the input on the web

Fixed Issues

$ #40181 (comment)
$ #48797

PROPOSAL:

Tests

Inline image preview

1. Open any chat room / page with Live Markdown input
2. Enter inline image markdown. For example:

*test* ![demo image](https://picsum.photos/id/1067/200/300)_test_ 

3. Verify the behavior of the input with image preview inside
4. Verify the loading indicator styling and layout before the image loads
5. Verify the size and aspect ratio of the image preview
6. Verify other cases where image can break the input

#48797

1. Initiate a DM with any user
2. Compose a message
3. Place the cursor in the middle of the composed message
4. Press the Delete button on the keyboard

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

web only feature

Android: mWeb Chrome

chrome.mov

iOS: Native

web only feature

iOS: mWeb Safari

ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

@dubielzyk-expensify @hungvu193 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

Do we need to use [image preview]? Wouldn't just using [image] be easier?

[shawnborton]

It seems like the height of the image jumps a bit when we load it... any ideas what's happening there? It goes from this:

To this:

[Skalakid]

Do we need to use [image preview]? Wouldn't just using [image] be easier?

I used image preview only as an example; you can type whatever you want there

[Skalakid]

It seems like the height of the image jumps a bit when we load it... any ideas what's happening there? It goes from this:

It's because I'm changing the source URL of the image, and the browser is loading it once again since it can be completely different image. While loading we are rendering the loading indicator that has 20px of height. The image loads pretty quick so loading indicator disappears instantly and that why we have a layout jump.

Also, on the screen shots that you posted I'm changing the URL variables (width and height) to get the image with different resolution, it's also the reason of the jump

[Skalakid]

@mountiny, can we get an adhoc build for testing so we can all easily verify how inline images behave in action, please?

[shawnborton]

Hmm I keep getting a broken image when I try this with the adhoc build, I've tried multiple URLs too:

[hungvu193]

just tried the adhoc build and I got the same issue with @shawnborton

Here's the logs:

[hungvu193]

It's working with Dev, so I assume that we will need to wait for BE to deploy to make it work with Staging, just like videos, we will need to whitelist these URL right? 😄

[hungvu193]

@Skalakid Can we add a debounce or wait until the user ends their inputting before another preview?

Screen.Recording.2024-09-16.at.21.39.29.mov

[Skalakid]

@hungvu193 I've added a debounce for inline image previews :D

[hungvu193]

@hungvu193 I've added a debounce for inline image previews :D

Awesome!. It's working! 🎉 .

I've found this bug, if you added multiple inline images at the same time, when you edit that message, the first image won't show up.

Screen.Recording.2024-09-17.at.17.58.04.mov

[hungvu193]

This bug is being handled here

[mvtglobally]

QA regression has been completed

[Skalakid]

Hello, thanks for the QA regression tests, I'm back at the office and I'm starting to investigate them

[Skalakid]

@lanitochka17 I wasn't able to reproduce the following issues, can you check it again, but with the latest main merged?

• mWeb - Task - Description entered is not shown in task preview

new.task.mov

• mWeb - Room - The text saved in the private notes section is not shown

private.notes.mov

[Skalakid]

@lanitochka17 Oh, okay, everything happens on Samsung devices.. I will continue the investigation tomorrow

[Skalakid]

Hello, here I created the PR with the fixes for the issues reported above

[Skalakid]

@hungvu193 @lanitochka17 The PR has been merged, so all reported bugs have been fixed :D Please verify it, and let's merge this feature into E/App

[hungvu193]

Thanks @Skalakid, I can verify that all the bugs above are fixed!

Just found a small bug, but I think we can address it in a follow-up PR. If we add the room description as an inline image, while clicking the image the RHP won't show up.

Screen.Recording.2024-09-30.at.18.10.28.mov

All yours @thienlnam

[thienlnam]

Thanks for sticking with this! Let's send it 🚀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[hungvu193]

@thienlnam can you create an issue for these issues?
#49250 (comment) and #49250 (comment)

[thienlnam]

We ended up reverting this PR to fix some other blockers - unfortunately, I think it will be tough to get this through without causing any issues. Let's see what we can address from the latest batch of reported issues and make sure we address any critical issues. Anything smaller that comes up we can probably address later and I'll denote that to the App deployer next time we merge this

[rafecolton]

Given that, can we merge a separate update that only updates the markdown library, so we can deploy the fix to #48797?

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mjasikowski]

@Skalakid just confirming that this has caused #49983, we'll need - we'll need to review composer scrolling with the new update

[VickyStash]

Also, this one caused this issue: #49973