-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new GBRs to task message #49389
base: main
Are you sure you want to change the base?
Add new GBRs to task message #49389
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@parasharrajat Please review the PR |
Screenshots🔲 iOS / native🔲 iOS / Safari🔲 MacOS / Desktop20.09.2024_14.44.37_REC.mp4🔲 MacOS / Chrome20.09.2024_14.40.15_REC.mp4🔲 Android / Chrome20.09.2024_14.48.53_REC.mp4🔲 Android / native20.09.2024_14.46.27_REC.mp4 |
Found some design things. Clarifying on the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cretadn22 Do you mind making changes to fix the design as requested here #49234 (comment)
Arrow should be vertically centered and inline with the task preview.
@parasharrajat I'm facing some challenges when trying to truncate the task title because we render the title as HTML in the task preview and don't use the text component. |
@cretadn22 I think in that case, it is best to just wrap tittle. |
@parasharrajat Currently, only the title is rendered by RenderHTML to handle completed task |
We can at least fix the wrapping when it is all text. @cretadn22 |
@parasharrajat Is this fine? |
@shawnborton Can you please help finalize the UI? #49389 (comment) |
Details
Fixed Issues
$ #49234
PROPOSAL: #49234 (comment)
Tests
OR
Offline tests
QA Steps
OR
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop