-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon color for saved search popup menu #49569
base: main
Are you sure you want to change the base?
Fix icon color for saved search popup menu #49569
Conversation
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-21.at.5.01.17.PM.movAndroid: mWeb ChromeScreen.Recording.2024-09-21.at.5.03.21.PM.moviOS: NativeScreen.Recording.2024-09-21.at.4.52.02.PM.moviOS: mWeb SafariScreen.Recording.2024-09-21.at.4.54.35.PM.movMacOS: Chrome / SafariScreen.Recording.2024-09-21.at.4.48.39.PM.movMacOS: DesktopScreen.Recording.2024-09-21.at.7.19.15.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also since this changes colors for saved seach popover, tagging @Expensify/design for review
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-21.at.5.01.17.PM.movAndroid: mWeb ChromeScreen.Recording.2024-09-21.at.5.03.21.PM.moviOS: NativeScreen.Recording.2024-09-21.at.4.52.02.PM.moviOS: mWeb SafariScreen.Recording.2024-09-21.at.4.54.35.PM.movMacOS: Chrome / SafariScreen.Recording.2024-09-21.at.4.48.39.PM.movMacOS: DesktopScreen.Recording.2024-09-21.at.7.19.15.PM.mov |
This issue is actually not entirely correct. Cause our default colors on popup is that the icon is green: But for the Search LHN we've changed the icon color to be green on active and grey on inactive. I kinda think we should do one of two things here:
I don't think we should treat this as an exception, but keen to hear what @Expensify/design things. cc @luacmartins |
@dubielzyk-expensify option 2 seems like a better choice but if it affects in too many places and we go for option 1, I think it should be still changed for mobile/narrow screens. It is not like a popup there, so it seems inconsistent on mobile devices. (the below screenshot is with changes from this PR) |
Yeah. I think if we did 1 and 2 we'd just do it as a separate follow-up. I'm not totally against creating a specific override here, but it just feels a bit off. Let's hear what @dannymcclain thinks. |
Ok I think this is my perspective: BUT I am a bit torn because I do prefer the update (Option 2) 😅 but am a little concerned about how many places an update like that would touch. ...Although we've been talking about making that change for a looooooong time now. I do agree with Jon that we should not treat this as exception though. Can we get any insight into the level of effort/scariness for pursuing Option 2? |
Details
The icon color inside three dot menu for saved search are incorrect.
Fixed Issues
$ #49440 (comment)
PROPOSAL: #49440 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop