Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] Update e2e dev instructions #50049

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hannojg
Copy link
Contributor

@hannojg hannojg commented Oct 2, 2024

Since we have switched to expo we can make the e2e dev instructions simpler. This PR is updating a section of the e2e developer guide (hence i skipped the default PR template).

(Note: i am hanno from margelo, an expert agency, we've build the e2e testing pipeline)

@hannojg hannojg requested a review from a team as a code owner October 2, 2024 11:31
@melvin-bot melvin-bot bot requested a review from aldo-expensify October 2, 2024 11:31
Copy link

melvin-bot bot commented Oct 2, 2024

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 2, 2024 11:31
@aldo-expensify aldo-expensify merged commit 66d1025 into Expensify:main Oct 2, 2024
6 of 9 checks passed
@melvin-bot melvin-bot bot added the Emergency label Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

@aldo-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Oct 2, 2024

Removed Emergency label. The PR Author and reviewer checklists were skipped because this is just updating documentation.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.44-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants