Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove add bank account page from central pane mapping #50228

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

daledah
Copy link
Contributor

@daledah daledah commented Oct 4, 2024

Details

Fixed Issues

$ #50214
PROPOSAL:

Tests

Precondition:

  1. WS has bank account, employee doesn't have bank account
  2. Employee submit expense, paid via Expensify

Steps:

  1. Click on the expense preview.
  2. Click on add bank account button.
  3. Verify that: The report view will persist when Add bank account RHP opens
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

  1. WS has bank account, employee doesn't have bank account
  2. Employee submit expense, paid via Expensify

Steps:

  1. Click on the expense preview.
  2. Click on add bank account button.
  3. Verify that: The report view will persist when Add bank account RHP opens
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-10-04.at.18.10.46.mov
Android: mWeb Chrome
Screen.Recording.2024-10-04.at.18.12.41.mov
iOS: Native
Screen.Recording.2024-10-04.at.18.14.55.mov
iOS: mWeb Safari
Screen.Recording.2024-10-04.at.18.16.20.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-04.at.17.58.45.mov
MacOS: Desktop
Screen.Recording.2024-10-04.at.18.20.58.mov

Copy link

melvin-bot bot commented Oct 4, 2024

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 4, 2024 11:25
@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 4, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android-app-2024-10-04_16.06.40.mp4
Android: mWeb Chrome
android-chrome-2024-10-04_16.09.11.mp4
iOS: Native
ios-app-2024-10-04_16.02.54.mp4
iOS: mWeb Safari
ios-safari-2024-10-04_16.01.54.mp4
MacOS: Chrome / Safari
desktop-chrome-2024-10-04_14.21.14.mp4
MacOS: Desktop
desktop-app-2024-10-04_16.10.15.mp4

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 4, 2024

@rushatgabhane Sorry for the ping! I'll take this one as it's a regression from a PR I was C+ on.

@jjcoffee

This comment was marked as outdated.

@jjcoffee

This comment was marked as outdated.

@jjcoffee

This comment was marked as resolved.

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 4, 2024

@daledah I think you forgot to do the revert you mentioned here.

@techievivek techievivek requested review from jjcoffee and removed request for rushatgabhane October 4, 2024 15:14
@daledah
Copy link
Contributor Author

daledah commented Oct 4, 2024

@jjcoffee I'm looking for a good solution to cover all possible cases for this bug. Might take a while.

@daledah
Copy link
Contributor Author

daledah commented Oct 4, 2024

@jjcoffee The invoices page reloads when I close the add bank account modal. Can you ping an Internal member to confirm this is expected or not? This screenshot is taken using default logic before #49230.

Screen.Recording.2024-10-05.at.04.47.46.mov

@techievivek
Copy link
Contributor

@daledah That looks like a bug, no? Why is the screen reloading? I don't think that's expected.

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 7, 2024

@daledah Yeah I don't think that's expected. Are you sure it was happening before your PR?

@daledah
Copy link
Contributor Author

daledah commented Oct 7, 2024

@jjcoffee Yes, I tested it with AddPersonalBankAccountPage reverted to before the changes.

Screen.Recording.2024-10-07.at.17.50.44.mp4

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 8, 2024

@daledah I don't see the behaviour on staging, are you saying your PR fixed this behaviour?

@daledah
Copy link
Contributor Author

daledah commented Oct 9, 2024

@jjcoffee Current staging sends user back to wallet page:

Navigation.navigate(ROUTES.SETTINGS_WALLET);

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 9, 2024

@daledah Oh, sorry! I think I get what you mean now. So when you introduced this change in your PR, that fixed an issue that was previously present.

Navigation.navigate(ROUTES.SETTINGS_WALLET);

I think if reverting that line fixes the issue here (i.e. correct navigation) and gets us back to the behaviour before the offending PR (i.e. page refreshes on closing the modal), that should be fine for this PR. Your original PR wasn't setting out to fix or modify anything to do with the modal itself, so I don't think it's within scope to fix that behaviour unless it's an easy tidy-up. Do you agree? @techievivek

@daledah
Copy link
Contributor Author

daledah commented Oct 10, 2024

@jjcoffee I updated and fixed some screens:

  1. Pay someone page
Screen.Recording.2024-10-10.at.17.51.46.mov
  1. Add bank account page
Screen.Recording.2024-10-10.at.17.53.30.mov
  1. Add wallet page
Screen.Recording.2024-10-10.at.17.57.23.mov
  1. Invoices page (The back button not navigate to wallet page - correct behavior, but the screen still reloads though)
Screen.Recording.2024-10-10.at.17.59.09.mov

Please let me know if there are places I missed

@jjcoffee
Copy link
Contributor

Thanks @daledah! What about this issue?

@daledah
Copy link
Contributor Author

daledah commented Oct 10, 2024

@jjcoffee It's also fixed.

Screen.Recording.2024-10-10.at.18.25.10.mov

@jjcoffee
Copy link
Contributor

@daledah There are conflicts.

Copy link
Contributor

@jjcoffee jjcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@techievivek techievivek merged commit 5215acc into Expensify:main Oct 14, 2024
17 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.49-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants