add create expense option to IOU actions #50239

pasyukevich · 2024-10-04T13:23:58Z

Details

Fixed Issues

$ #49691
PROPOSAL:

Tests

Verify that no errors appear in the JS console

For selfDM:

Assert you have the combinedTrackSubmit beta enabled in your account.
Open selfDM
Open the Create menu inside the DM
Click the Create expense option to open the page, assert the page's title is Create expense.
Click the Manual tab, insert an amount and click Next to navigate to the next page. Assert the page's title is Track expense and there is a Submit button.
Confirm and assert the expense was tracked.

For DM:

Assert you have the combinedTrackSubmit beta enabled in your account.
Open DM with anybody else
Open the Create menu inside the DM
Click the Create expense option to open the page, assert the page's title is Create expense.
Click the Manual tab, insert an amount and click Next to navigate to the next page. Assert the page's title is Submit expense and there is a Submit button.
Confirm and assert the expense was tracked.

For Workspace:

Assert you have the combinedTrackSubmit beta enabled in your account.
Openanre Workspace chat
Open the Create menu inside the Workspace
Click the Create expense option to open the page, assert the page's title is Create expense.
Click the Manual tab, insert an amount and click Next to navigate to the next page. Assert the page's title is Submit expense and there is a Submit button.
Confirm and assert the expense was tracked.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

[native-android-converted.webm](https://github.com/user-attachments/assets/73a145c5-2a40-4ab7-b6f4-577abc691ad8)

Android: mWeb Chrome

web-android-converted.webm

iOS: Native

native-ios-converted.mp4

iOS: mWeb Safari

web-ios-converted.mp4

MacOS: Chrome / Safari

web-converted.mov

MacOS: Desktop

desktop-converted.mov

fabioh8010 · 2024-10-07T07:26:05Z

src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

+            const trackOnlyCreateExpense = {
+                icon: getIconForAction(CONST.IOU.TYPE.CREATE),
+                text: translate('iou.createExpense'),
+                onSelected: () => selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK, report?.reportID ?? '-1'), true),
+            };


You could just reuse the object from options, no?

No, since we need to use the before methods for onSelected, but the new icon and text

updated to reuse

fabioh8010 · 2024-10-07T07:26:11Z

src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

+            const submitOnlyCreateExpense = {
+                icon: getIconForAction(CONST.IOU.TYPE.CREATE),
+                text: translate('iou.createExpense'),
+                onSelected: () => selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, report?.reportID ?? '-1'), true),
+            };


melvin-bot · 2024-10-07T13:06:50Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-10-07T15:31:49Z

src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

@@ -168,10 +170,58 @@ function AttachmentPickerWithMenuItems({
            },
        };

-        return ReportUtils.temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs ?? []).map((option) => ({
+        let list: PopoverMenuItem[] = ReportUtils.temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs ?? []).map((option) => ({


We should avoid using let

Could we use a more descriptive name for this variable?

grgia · 2024-10-07T15:35:30Z

src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

+            if (list.some((option) => options[CONST.IOU.TYPE.TRACK].text === option.text) && list.some((option) => options[CONST.IOU.TYPE.SUBMIT].text === option.text)) {
+                list = list.reduce((acc, item) => {
+                    if (item.text === translate('iou.submitExpense')) {
+                        acc.push(submitOnlyCreateExpense);
+                    } else if (item.text !== translate('iou.trackExpense')) {
+                        acc.push(item);
+                    }
+
+                    return acc;
+                }, [] as PopoverMenuItem[]);
+            } else if (list.some((option) => options[CONST.IOU.TYPE.TRACK].text === option.text)) {
+                list = list.reduce((acc, item) => {
+                    if (item.text === translate('iou.trackExpense')) {
+                        acc.push(trackOnlyCreateExpense);
+                    } else {
+                        acc.push(item);
+                    }
+
+                    return acc;
+                }, [] as PopoverMenuItem[]);


Would it be easier to not add the other options to the list in the first place?

Updated to the approach without new elements

rushatgabhane · 2024-10-09T07:15:48Z

@pasyukevich please fix eslint

pasyukevich · 2024-10-09T09:39:23Z

@rushatgabhane PR updated

grgia · 2024-10-09T16:02:57Z

@rushatgabhane could you prioritize this review please?

fabioh8010 · 2024-10-11T17:28:06Z

@rushatgabhane Bump 😅

rushatgabhane · 2024-10-14T02:52:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-14.at.09.00.01.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-10-14.at.08.54.27.mov

Screen.Recording.2024-10-14.at.08.55.47.mov

MacOS: Desktop

rushatgabhane · 2024-10-14T03:28:22Z

Should the confirmation page after Create expense say Submit expense?

rushatgabhane · 2024-10-14T03:29:55Z

Also, should the quick action say submit expense?

rushatgabhane

Above issues are unrelated but just noting them down, rest LGTM!

grgia · 2024-10-14T06:57:59Z

Thank you @rushatgabhane, I think we'll need to check with Anu about #50239 (comment) but neither point is a blocker for this PR

grgia

LGTM

OSBotify · 2024-10-14T07:08:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:30:38Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-17T01:45:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pasyukevich added 2 commits October 4, 2024 15:22

add create expense option to IOU actions

eaae14b

fix titles for the tabs at IOU start page

a1d92ef

pasyukevich force-pushed the feature/create-expense-update branch from f7ed357 to a1d92ef Compare October 4, 2024 19:24

Merge branch 'main' into feature/create-expense-update

5a0f9a0

fabioh8010 reviewed Oct 7, 2024

View reviewed changes

Merge branch 'main' into feature/create-expense-update

167af2f

pasyukevich marked this pull request as ready for review October 7, 2024 13:06

pasyukevich requested a review from a team as a code owner October 7, 2024 13:06

melvin-bot bot requested a review from rushatgabhane October 7, 2024 13:06

melvin-bot bot removed the request for review from a team October 7, 2024 13:06

grgia self-requested a review October 7, 2024 15:29

grgia reviewed Oct 7, 2024

View reviewed changes

change the approach to using filter

f6e9d87

pasyukevich force-pushed the feature/create-expense-update branch from e8149eb to f6e9d87 Compare October 7, 2024 21:35

Merge branch 'main' into feature/create-expense-update

d590354

grgia approved these changes Oct 9, 2024

View reviewed changes

rushatgabhane approved these changes Oct 14, 2024

View reviewed changes

melvin-bot bot requested a review from grgia October 14, 2024 03:37

grgia approved these changes Oct 14, 2024

View reviewed changes

grgia merged commit 4a3f2da into Expensify:main Oct 14, 2024
18 of 19 checks passed

github-actions bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

IuliiaHerets mentioned this pull request Oct 15, 2024

Expense - Track expense button displayed instead of Submit when creating expense in self DM #50826

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) #49691

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add create expense option to IOU actions #50239

add create expense option to IOU actions #50239

pasyukevich commented Oct 4, 2024 •

edited

Loading

fabioh8010 Oct 7, 2024

pasyukevich Oct 7, 2024

pasyukevich Oct 7, 2024

fabioh8010 Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

grgia Oct 7, 2024

grgia Oct 7, 2024

pasyukevich Oct 7, 2024

grgia Oct 7, 2024

pasyukevich Oct 7, 2024

rushatgabhane commented Oct 9, 2024

pasyukevich commented Oct 9, 2024

grgia commented Oct 9, 2024

fabioh8010 commented Oct 11, 2024

rushatgabhane commented Oct 14, 2024 •

edited

Loading

rushatgabhane commented Oct 14, 2024 •

edited

Loading

rushatgabhane commented Oct 14, 2024

rushatgabhane left a comment •

edited

Loading

grgia commented Oct 14, 2024

grgia left a comment

OSBotify commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

add create expense option to IOU actions #50239

add create expense option to IOU actions #50239

Conversation

pasyukevich commented Oct 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rushatgabhane commented Oct 9, 2024

pasyukevich commented Oct 9, 2024

grgia commented Oct 9, 2024

fabioh8010 commented Oct 11, 2024

rushatgabhane commented Oct 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Oct 14, 2024 • edited Loading

rushatgabhane commented Oct 14, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

grgia commented Oct 14, 2024

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

pasyukevich commented Oct 4, 2024 •

edited

Loading

rushatgabhane commented Oct 14, 2024 •

edited

Loading

rushatgabhane commented Oct 14, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading