-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [Direct Feeds] Update Feed switcher label #50972
[No QA] [Direct Feeds] Update Feed switcher label #50972
Conversation
# Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-18.at.3.30.57.PM.movAndroid: mWeb ChromeScreen.Recording.2024-10-18.at.3.34.13.PM.moviOS: NativeScreen.Recording.2024-10-18.at.3.24.41.PM.moviOS: mWeb SafariScreen.Recording.2024-10-18.at.3.20.38.PM.movMacOS: Chrome / SafariScreen.Recording.2024-10-18.at.3.18.01.PM.movMacOS: DesktopScreen.Recording.2024-10-18.at.3.21.19.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks neat!
Putting a note:
There is a onyx error on native devices this is because the
BE
returns[]
instead of{}
, we need to fix that 🚀 (details here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nab comment
@@ -211,46 +232,18 @@ function getCardFeedName(feedType: CompanyCardFeed): string { | |||
[CONST.COMPANY_CARD.FEED_BANK_NAME.MASTER_CARD]: 'Mastercard', | |||
[CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX]: 'American Express', | |||
[CONST.COMPANY_CARD.FEED_BANK_NAME.STRIPE]: 'Stripe', | |||
[CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX_DIRECT]: 'American Express', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use official consts for the names too
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
This was not an emergency, probably the checklist check started to run again before i merged |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.52-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀
|
Details
[Direct Feeds] Update Feed switcher label
Fixed Issues
$ #50452
PROPOSAL: N/A
Tests
companyCardFeeds
anddirectFeeds
betas are turned on.Offline tests
Same, as in the
Tests
sectionQA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop