Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen." #51014

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen." #51014

merged 1 commit into from
Oct 17, 2024
+4 −42

Conversation

lakchote
Copy link
Contributor

Reverts blocker #51003

@lakchote lakchote self-assigned this Oct 17, 2024
@lakchote lakchote requested a review from a team as a code owner October 17, 2024 13:00
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 17, 2024

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 17, 2024 13:00
@MarioExpensify MarioExpensify merged commit ee384b0 into main Oct 17, 2024
14 of 16 checks passed
@MarioExpensify MarioExpensify deleted the revert-47370-krishna2323/issue/47100 branch October 17, 2024 13:18
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 17, 2024

@MarioExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Oct 17, 2024
@lakchote
Copy link
Contributor Author

Not an emergency. It's a straight revert.

@lakchote lakchote mentioned this pull request Oct 17, 2024
Merged
50 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 17, 2024
@MarioExpensify @OSBotify
Merge pull request #51014 from Expensify/revert-47370-krishna2323/iss…
8f508df 
…ue/47100

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen."

(cherry picked from commit ee384b0)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 17, 2024
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Closed
90 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.50-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@lakchote lakchote mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioExpensify MarioExpensify MarioExpensify approved these changes

Assignees

@lakchote lakchote

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakchote @OSBotify @MarioExpensify