-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contacts import #51018
Contacts import #51018
Conversation
Thanks for the recording @perunt . Looks good 👍 |
…contacts-import
It becomes overdue very quickly 🥲 |
@blimpich is there anything else I can help with? |
No I think we're good with this PR! Thank you! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Hey all. I am sorry but I need to revert this one. We merged major changes to the HybridApp repo and build process earlier today and this is likely to conflict. Here is an internal discussion for anyone with access. |
Hopefully we should be able to resubmit quickly. |
@Julesssss Let's me know when we can re-submit this PR |
@DylanDylann I'll follow along and let us know when we're good to try and merge again. |
Our main worry is conflicts due to similar files being touched. Once this issue is resolved and build issues are resolved (we expect many), you should be good to go! |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.75-0 🚀
|
Do we need to QA this? Can I check it off as it was reverted #53961 |
@mvtglobally no QA required. thank you |
@blimpich sure, I'll do it later today |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
Details
In this PR, we've implemented a Nitro Module for accessing device contacts (iOS, Android) for native mobile platforms only. Key implementation details:
Utilized nitro-codegen for auto-generating bindings and supporting files
Based on react-native-nitro-template
Most code in modules/NitroContactModule is auto-generated through Nitro's toolchain
Most implementation is auto-generated, please focus review on:
And the rest JS code
Fixed Issues
$ #47938
PROPOSAL:
Tests
Offline tests
QA Steps
Scenario 1: Permission Granted
Scenario 2: Permission Denied
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
R_ex.mp4
Android: mWeb Chrome
iOS: Native
RPReplay_Final1732184706.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop