-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page #51171
fix: Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page #51171
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-21.at.22.24.36.mp4Android: mWeb ChromeScreen.Recording.2024-10-21.at.22.25.11.mp4iOS: NativeScreen.Recording.2024-10-21.at.22.23.17.mp4iOS: mWeb SafariScreen.Recording.2024-10-21.at.22.23.43.mp4MacOS: Chrome / SafariScreen.Recording.2024-10-21.at.22.21.35.mp4Warning: Warning: Warning: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The performance tests pipeline failure, which is unstable at ReportScreen, seems unrelated to the scope of this issue, so I think we can proceed with this PR
@etCoderDysto Could you please try to merge latest main to resolve github action has mentioned at this thread? |
@suneox I have merged the latest main. |
Thank you, time to waiting pipeline for perf-test then we can process this PR |
The pipeline has been passed, all for you @grgia |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.53-0 🚀
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.53-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀
|
Details
We added
styles.gap2
between Add rate and Settings button on Taxes page to make the gap consistent with Distance rate page, and Categories pageFixed Issues
$ #50569
PROPOSAL: #50569 (comment)
Tests
Offline tests
Same as test steps
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
mweb.chrome.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
safari.mp4
MacOS: Chrome / Safari
Web.mp4
MacOS: Desktop
desktop.mp4