-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/20459 sub steps refactor #51231
Open
burczu
wants to merge
52
commits into
Expensify:main
Choose a base branch
from
burczu:feature/20459-sub-steps-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,303
−1,706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burczu
force-pushed
the
feature/20459-sub-steps-refactor
branch
from
October 23, 2024 05:35
7125bea
to
0136b74
Compare
melvin-bot
bot
requested review from
hungvu193
and removed request for
a team
October 24, 2024 09:32
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
at first glance looks nice! great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In this PR I've refactored some parts of the code related to sub-steps forms that we recently use more extensively in the App. These improvements was discussed with @koko57 and @MrMuzyk - it will be useful in the Global Reimbursement project where we create more sub-steps forms. The PR introduces few re-usable common form components like
FullNameStep
,DateOfBirthStep
,AddressStep
orSingleFieldStep
(that can be used for e.g. phone numbers or social security numbers) ones and uses them wherever applicable. It also makes the InteractiveStepWrapper component more re-usable.Fixed Issues
$ #50893
PROPOSAL: n/a
Tests
Enable payments:
Reimbursement account - personal info:
Reimbursement account - beneficial owner info:
Missing personal info for issuing the card:
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Enable payments:
Screen.Recording.2024-10-24.at.09.02.09.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.09.10.28.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.09.13.44.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.09.18.03.mov
Android: mWeb Chrome
Enable payments:
Screen.Recording.2024-10-24.at.10.32.27.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.10.40.06.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.10.43.18.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.10.36.08.mov
iOS: Native
Enable payments:
Screen.Recording.2024-10-24.at.08.27.37.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.08.31.24.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.08.36.38.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.08.45.54.mov
iOS: mWeb Safari
Enable payments:
Screen.Recording.2024-10-24.at.09.41.31.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.10.15.04.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.10.24.29.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.09.50.48.mov
MacOS: Chrome / Safari
Enable payments:
Screen.Recording.2024-10-23.at.09.31.28.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.07.27.46.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.07.45.42.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.07.51.18.mov
MacOS: Desktop
Enable payments:
Screen.Recording.2024-10-24.at.08.03.18.mov
Reimbursement account - personal info:
Screen.Recording.2024-10-24.at.08.06.26.mov
Reimbursement account - beneficial owner info:
Screen.Recording.2024-10-24.at.08.09.56.mov
Missing personal info for issuing the card:
Screen.Recording.2024-10-24.at.08.13.40.mov