Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" #51245

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[CP Staging] Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" #51245

merged 1 commit into from
Oct 22, 2024

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Oct 22, 2024 •
edited
Loading

Reverts #49592

This seems to fix this deploy blocker issue where expensifail accounts don't see the track expense FAB option.

This branch
Screenshot 2024-10-22 at 13 47 04

Staging
Screenshot 2024-10-22 at 13 49 30

@Julesssss Julesssss self-assigned this Oct 22, 2024
@Julesssss Julesssss mentioned this pull request Oct 22, 2024
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51245/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51245/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51245/NewExpensify.dmg https://51245.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@Julesssss Julesssss marked this pull request as ready for review October 22, 2024 12:49
@Julesssss Julesssss requested a review from a team as a code owner October 22, 2024 12:49
@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team October 22, 2024 12:50
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 22, 2024

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss Julesssss added the CP Staging marks PRs that have been CP'd to staging label Oct 22, 2024
@Julesssss
Copy link
Contributor Author

Changed files ESLint check / Changed files ESLint check (pull_request)

We can ignore this failing check. This occurs because we are removing the code which just migrated to useOnyx

@Julesssss Julesssss mentioned this pull request Oct 22, 2024
Merged
50 tasks
mountiny
mountiny approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@shubham1206agra
Copy link
Contributor

@fabioh8010 Can you look into this?

@mountiny mountiny merged commit 635cd11 into main Oct 22, 2024
13 of 18 checks passed
@mountiny mountiny deleted the revert-49592-feature/combined-expense-flow-48787-withOnyx-migration branch October 22, 2024 13:03
@melvin-bot melvin-bot bot added the Emergency label Oct 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 22, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert so we do not have to wait for the tests to pass

@mountiny mountiny changed the title Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" [CP Staging] Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" Oct 22, 2024
OSBotify pushed a commit that referenced this pull request Oct 22, 2024
@mountiny @OSBotify
Merge pull request #51245 from Expensify/revert-49592-feature/combine…
a10119a 
…d-expense-flow-48787-withOnyx-migration

Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit"

(cherry picked from commit 635cd11)

(CP triggered by Julesssss)
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Closed
74 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.52-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@fabioh8010
Copy link
Contributor

@shubham1206agra Yep, will look into this 👍 Will track progress here.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@dangrous dangrous Awaiting requested review from dangrous

Assignees

@Julesssss Julesssss

Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAB - Track expense option is not present in FAB for Expensifail account
5 participants
@Julesssss @shubham1206agra @mountiny @OSBotify @fabioh8010