Fix: Expense - Not here page shows up briefly when deleting the expense #52740

wildan-m · 2024-11-19T06:08:36Z

Explanation of Change

This PR will not here page briefly appears when deleting the expense by navigating to target url then perform actual delete when the report details unmounted.

Fixed Issues

$ #45576
PROPOSAL: #45576 (comment)

Tests

Open App
Go to DM.
Submit two expenses to the user.
Open any of the transaction thread.
Tap on the report header.
Tap Delete expense..
Delete the expense.
Verify Not here page will not show up when deleting the expense.
Verify [Deleted Expense] text not shown in report details page

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2024-11-19.at.12.55.58.mp4

Android: mWeb Chrome

Kapture.2024-11-19.at.12.53.50.mp4

iOS: Native

Kapture.2024-11-19.at.11.07.05.mp4

iOS: mWeb Safari

Kapture.2024-11-19.at.11.13.30.mp4

MacOS: Chrome / Safari

Kapture.2024-11-19.at.11.10.45.mp4

MacOS: Desktop

Kapture.2024-11-19.at.12.39.18.mp4

…e..] briefly appeared

…x/45576-fix-not-found-decouple-2

…ion during delete process

…ppear

…x/45576-fix-not-found-decouple-2

…t, to resolve not found page briefly appeared

…x/45576-fix-not-found-decouple-2

…necessary code

…x/45576-fix-not-found-decouple-2

wildan-m · 2024-11-26T07:59:17Z

@alitoshmatov Thanks for your feedback I've got this loading error in dev and staging

Seems BE?
Unexpected error deleting this expense. Please try again later

Kapture.2024-11-26.at.14.51.26.mp4

I'll try to fix the issue after that BE issue resolved

luacmartins · 2024-11-26T17:08:18Z

@wildan-m is that consistently reproducible? Do you have a requestID for a failing request?

wildan-m · 2024-11-27T01:10:55Z

@luacmartins yes, it consistently reproduced, I think it's FE.

Asking if anyone else has experienced the same.
https://expensify.slack.com/archives/C01GTK53T8Q/p1732632553483729

…x/45576-fix-not-found-decouple-2

wildan-m · 2024-11-28T02:10:07Z

@alitoshmatov can you retest with this new merged main? I can't reproduce your mentioned issue I can only reproduce the loading issue which is also occurred in staging.

wildan-m · 2024-11-28T03:18:37Z

@wildan-m When expense has a comment, navigation is behaving a little bit different. When you delete the expense:

Modal is closing

Existing expense page is shown

Then Expense report is shown

@alitoshmatov actually that behavior is current staging behavior, we can't see that clearly because it's deleting and navigation fast. If we throttle the CPU, we'll see it better

IIRC the expected behavior if there is a comment when deleting expense is -- it should navigate to the existing expense page, not the parent report. @luacmartins do you know if the expected behavior changes?

Kapture.2024-11-28.at.10.07.04.mp4

Should we fix that here?

edit:

I've found the offending PR, this PR cause the change of behavior

#45563

Also, I've noticed that isDeletedParentAction returned by DeleteMoneyRequest API is false, where it expected to be true

luacmartins · 2024-12-02T16:10:59Z

Also, I've noticed that isDeletedParentAction returned by DeleteMoneyRequest API is false, where it expected to be true

I found the backend bug for this. I'll work on a fix.

luacmartins · 2024-12-02T16:14:38Z

IIRC the expected behavior if there is a comment when deleting expense is -- it should navigate to the existing expense page, not the parent report. @luacmartins do you know if the expected behavior changes?

It seems like the behavior has changed as you mentioned.

alitoshmatov · 2024-12-02T19:24:46Z

@alitoshmatov actually that behavior is current staging behavior, we can't see that clearly because it's deleting and navigation fast. If we throttle the CPU, we'll see it better

I see

if there is a comment when deleting expense is -- it should navigate to the existing expense page, not the parent report

So we decided the behavior should be as you said, right?

luacmartins · 2024-12-02T21:19:20Z

That's my understanding

wildan-m · 2024-12-03T12:40:17Z

@luacmartins @alitoshmatov should we fix the behavior that accidentally changed by this PR #45563 here?

luacmartins · 2024-12-03T19:08:50Z

I don't think we should change that as part of this PR. If we decide to change it, we should do so in a separate one.

wildan-m · 2024-12-03T23:08:18Z

I don't think we should change that as part of this PR. If we decide to change it, we should do so in a separate one.

@luacmartins @alitoshmatov Then should this behavior be accepted, since the navigation successfully takes us to the correct screen, but then the useEffect in ReportScreen re-navigates us to the parent report. Right?

alitoshmatov · 2024-12-04T17:24:54Z

@luacmartins @alitoshmatov Then should #52740 (comment) be accepted, since the navigation successfully takes us to the correct screen, but then the useEffect in ReportScreen re-navigates us to the parent report. Right?

I think so. I will finish up the checklist then

luacmartins · 2024-12-04T17:25:39Z

Yes, I agree.

alitoshmatov · 2024-12-04T19:20:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

invoice-delete-android.mov

Android: mWeb Chrome

iOS: Native

invoice-delete-ios.mp4

iOS: mWeb Safari

invoice-delete-safari.mp4

MacOS: Chrome / Safari

invoice-delete-web.mov

MacOS: Desktop

invoice-delete-desktop.mov

alitoshmatov

LGTM!

OSBotify · 2024-12-04T19:46:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

wildan-m · 2024-12-05T03:02:14Z

@luacmartins @alitoshmatov I just remember that there is a feedback on successData regarding similar pattern we use here. To avoid similar issue should we patch this PR a bit? we'll make the success data to null instead. Here is the patch #53616

github-actions · 2024-12-05T15:17:02Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:02:08Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-09T16:05:23Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

wildan-m added 30 commits October 6, 2024 01:29

Change behavior, navigate before transaction delete to resolve [delet…

7d69e66

…e..] briefly appeared

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

b32c78b

…x/45576-fix-not-found-decouple-2

fix incorrect reportIDToNavigateBack

bc8f8ed

actually delete the transaction after ReportDetailsPage unmounted

f6781e6

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

5b205e6

…x/45576-fix-not-found-decouple-2

Refactor, remove unnecessary code

0bd45cc

Add NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL to show loading transact…

eb051bb

…ion during delete process

prettier

c2cecdc

Refactor

7e8d4f4

Partially DeleteTransactionThread to prevent not found page briefly a…

66e3de8

…ppear

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

9ec0a26

…x/45576-fix-not-found-decouple-2

decouple urlToNavigateBack functions

9bce4f0

actually delete transaction after reportdetailspage unmounted

e2cd642

Resolve cyclic dependency

980e8e5

extract navagateUrl from prepareToCleanUpMoneyRequest

0288efb

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

aef7070

…x/45576-fix-not-found-decouple-2

Implement NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL

5d982cc

change delete money request and track expense to merge instead of fas…

4447344

…t, to resolve not found page briefly appeared

show skeleton when deleting processed

71c3d41

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

82668c5

…x/45576-fix-not-found-decouple-2

remove unnecessary code

390d357

prettier

576e194

lint & prettier

7145f31

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

1256e03

…x/45576-fix-not-found-decouple-2

Ensure report skeleton hide after interaction and update completed

a343297

Remove unused import

e41e182

Move navigateToTargetUrl to onModalHide, fix potential bug, remove un…

7123b2f

…necessary code

lint

19dccb4

Refactor for more accurate function name

6c96672

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

38a7323

…x/45576-fix-not-found-decouple-2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

71728f6

…x/45576-fix-not-found-decouple-2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

fd39c99

…x/45576-fix-not-found-decouple-2

luacmartins self-requested a review December 4, 2024 17:26

luacmartins approved these changes Dec 4, 2024

View reviewed changes

alitoshmatov approved these changes Dec 4, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins December 4, 2024 19:20

luacmartins approved these changes Dec 4, 2024

View reviewed changes

luacmartins merged commit c049ac7 into Expensify:main Dec 4, 2024
17 of 18 checks passed

wildan-m mentioned this pull request Dec 5, 2024

patch success data to prevent issue report object not considered to null #53616

Merged

50 tasks

github-actions bot mentioned this pull request Dec 5, 2024

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

43 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Expense - Not here page shows up briefly when deleting the expense #52740

Fix: Expense - Not here page shows up briefly when deleting the expense #52740

wildan-m commented Nov 19, 2024

wildan-m commented Nov 26, 2024

luacmartins commented Nov 26, 2024

wildan-m commented Nov 27, 2024

wildan-m commented Nov 28, 2024

wildan-m commented Nov 28, 2024 •

edited

Loading

luacmartins commented Dec 2, 2024

luacmartins commented Dec 2, 2024

alitoshmatov commented Dec 2, 2024

luacmartins commented Dec 2, 2024

wildan-m commented Dec 3, 2024

luacmartins commented Dec 3, 2024

wildan-m commented Dec 3, 2024

alitoshmatov commented Dec 4, 2024 •

edited

Loading

luacmartins commented Dec 4, 2024

alitoshmatov commented Dec 4, 2024

alitoshmatov left a comment

OSBotify commented Dec 4, 2024

wildan-m commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 9, 2024

Fix: Expense - Not here page shows up briefly when deleting the expense #52740

Fix: Expense - Not here page shows up briefly when deleting the expense #52740

Conversation

wildan-m commented Nov 19, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

wildan-m commented Nov 26, 2024

luacmartins commented Nov 26, 2024

wildan-m commented Nov 27, 2024

wildan-m commented Nov 28, 2024

wildan-m commented Nov 28, 2024 • edited Loading

luacmartins commented Dec 2, 2024

luacmartins commented Dec 2, 2024

alitoshmatov commented Dec 2, 2024

luacmartins commented Dec 2, 2024

wildan-m commented Dec 3, 2024

luacmartins commented Dec 3, 2024

wildan-m commented Dec 3, 2024

alitoshmatov commented Dec 4, 2024 • edited Loading

luacmartins commented Dec 4, 2024

alitoshmatov commented Dec 4, 2024

Reviewer Checklist

Screenshots/Videos

alitoshmatov left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 4, 2024

wildan-m commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 9, 2024

wildan-m commented Nov 28, 2024 •

edited

Loading

alitoshmatov commented Dec 4, 2024 •

edited

Loading