Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide search skeleton empty view scrollbar #53730

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/EmptyStateComponent/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function EmptyStateComponent({
headerStyles,
headerContentStyles,
lottieWebViewStyles,
showsVerticalScrollIndicator,
minModalHeight = 400,
}: EmptyStateComponentProps) {
const styles = useThemeStyles();
Expand Down Expand Up @@ -83,6 +84,7 @@ function EmptyStateComponent({

return (
<ScrollView
showsVerticalScrollIndicator={showsVerticalScrollIndicator}
contentContainerStyle={[{minHeight: minModalHeight}, styles.flexGrow1, styles.flexShrink0, containerStyles]}
style={styles.flex1}
>
Expand Down
1 change: 1 addition & 0 deletions src/components/EmptyStateComponent/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type SharedProps<T> = {
headerContentStyles?: StyleProp<ViewStyle & ImageStyle>;
lottieWebViewStyles?: React.CSSProperties | undefined;
minModalHeight?: number;
showsVerticalScrollIndicator?: boolean;
};

type MediaType<HeaderMedia, T extends MediaTypes> = SharedProps<T> & {
Expand Down
1 change: 1 addition & 0 deletions src/pages/Search/EmptySearchView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ function EmptySearchView({type, hasResults}: EmptySearchViewProps) {
<>
<EmptyStateComponent
SkeletonComponent={SearchRowSkeleton}
showsVerticalScrollIndicator={false}
headerMediaType={CONST.EMPTY_STATE_MEDIA.ANIMATION}
headerMedia={content.headerMedia}
headerStyles={[styles.emptyStateCardIllustrationContainer, styles.overflowHidden]}
Expand Down
Loading