Fix IOU amount input flicking #53740

QichenZhu · 2024-12-08T23:56:53Z

Explanation of Change

Fixed Issues

$ #53286
PROPOSAL: #53286 (comment)

Tests

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.

Verify that no errors appear in the JS console

Offline tests

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.

QA Steps

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
Unit tests are not added as this fixes a styling issue.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

melvin-bot · 2024-12-08T23:56:57Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-12-09T02:23:55Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2024-12-09T03:09:50Z

Gonna run a test build here to test performance. The bug looks gone, but the input field looks very stuttery.

dubielzyk-expensify · 2024-12-09T03:53:46Z

@shawnborton any idea why the test build couldn't run?

shawnborton · 2024-12-09T13:32:45Z

Ah, you just need to make sure the label Ready to build is applied first. Let me add that and re-run for ya!

github-actions · 2024-12-09T13:33:31Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-09T13:58:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53740/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53740/NewExpensify.dmg	https://53740.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

brunovjk · 2024-12-09T14:50:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

53286_android_native.mov

Android: mWeb Chrome

53286_android_web.mov

iOS: Native

53286_ios_native.mov

iOS: mWeb Safari

53286_ios_web.mov

MacOS: Chrome / Safari

53286_web_chrome.mov

MacOS: Desktop

53286_web_desktop.mov

brunovjk · 2024-12-09T14:52:59Z

I can reproduce the issue The digit exceeding the max allowed decimal places is briefly inserted into the input
on my tests, it is not related to our PR.

brunovjk · 2024-12-09T14:55:32Z

The main issue is gone, I'll do more tests, after lunch, to avoid regressions. @QichenZhu do you think we need to create a unit test here? Thanks.

QichenZhu · 2024-12-09T23:47:40Z

do you think we need to create a unit test here?

@brunovjk Based on the info below, I don't think we need unit tests.

https://github.com/Expensify/App/blob/c666ade576e530302685bbd62056451342bac260/tests/ui/README.md#when-to-skip-tests

Contributors may skip tests in the following cases:

Non-Functional Changes: E.g styling updates, github workflow changes, translation updates or refactors without behavioral changes.

dubielzyk-expensify · 2024-12-10T01:10:23Z

Thanks Shawn!

Tested this on Android and it's working well 👍

dubielzyk-expensify

Approve from a visual perspective. I'll let others handle the rest :)

brunovjk · 2024-12-10T11:31:32Z

Great! I'll do some tests and we'll have it by EOD. @QichenZhu could you complete your checklist? Thanks you

brunovjk · 2024-12-10T17:10:28Z

src/styles/utils/index.ts

@@ -1290,6 +1290,13 @@ const createStyleUtils = (theme: ThemeColors, styles: ThemeStyles) => ({
        };
    },

+    getAutoGrowWidthInputContainerStyles: (width: number, extraSpace: number): ViewStyle => {


Should we add comment explaining this function?

brunovjk

Apart from the incomplete checklist and the addition of JSDOC, everything looks good to me.

src/styles/utils/index.ts

QichenZhu · 2024-12-11T00:35:03Z

Checklist completed, except for the unit tests check. Explained here: #53740 (comment).

brunovjk · 2024-12-11T00:56:27Z

Checklist completed, except for the unit tests check. Explained here: #53740 (comment).

Since you provided reasons, you can check this option in the list anyway, to remove the ❌

neil-marcellini

Looks good, thanks for the note about the existing issue.

OSBotify · 2024-12-11T17:54:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-12T01:59:20Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

luacmartins · 2024-12-12T19:34:30Z

FYI I'm reverting this PR because it caused this blocker #53992

github-actions · 2024-12-13T15:41:25Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

QichenZhu added 6 commits December 8, 2024 01:07

Fix IOU amount input flicking

2eb73a3

Use StyleUtils

3ffff5d

Increase spacing

267eb39

Merge remote-tracking branch 'upstream/main' into fix/53286

c6f7fb6

Lift prop to a parent component to limit its scope

0958370

Remove outdated comments

b8fdae8

QichenZhu changed the title ~~Fix/53286~~ Fix IOU amount input flicking Dec 8, 2024

Apply the same approach to web platforms

f20c05d

QichenZhu marked this pull request as ready for review December 9, 2024 02:23

QichenZhu requested review from a team as code owners December 9, 2024 02:23

melvin-bot bot requested a review from brunovjk December 9, 2024 02:23

melvin-bot bot removed the request for review from a team December 9, 2024 02:23

shawnborton added the Ready To Build label Dec 9, 2024

dubielzyk-expensify previously approved these changes Dec 10, 2024

View reviewed changes

brunovjk reviewed Dec 10, 2024

View reviewed changes

brunovjk approved these changes Dec 10, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini December 10, 2024 17:23

QichenZhu commented Dec 11, 2024

View reviewed changes

src/styles/utils/index.ts Show resolved Hide resolved

QichenZhu dismissed dubielzyk-expensify’s stale review via 04b8db1 December 11, 2024 00:01

Add comment

04b8db1

neil-marcellini approved these changes Dec 11, 2024

View reviewed changes

neil-marcellini merged commit 18bbf5f into Expensify:main Dec 11, 2024
17 of 18 checks passed

github-actions bot mentioned this pull request Dec 12, 2024

Deploy Checklist: New Expensify 2024-12-12 #53978

Closed

55 tasks

This was referenced Dec 12, 2024

Revert "Fix IOU amount input flicking" #54060

Merged

[HOLD for payment 2024-12-20] [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes #53992

Closed

melvin-bot bot mentioned this pull request Dec 13, 2024

[HOLD for payment 2024-12-20] [$250] BNP-On entering number&decimal point, first digit moves inwards slightly #53286

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix IOU amount input flicking #53740

Fix IOU amount input flicking #53740

QichenZhu commented Dec 8, 2024 •

edited

Loading

melvin-bot bot commented Dec 8, 2024

melvin-bot bot commented Dec 9, 2024

dubielzyk-expensify commented Dec 9, 2024

dubielzyk-expensify commented Dec 9, 2024 •

edited

Loading

shawnborton commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

brunovjk commented Dec 9, 2024

brunovjk commented Dec 9, 2024 •

edited

Loading

brunovjk commented Dec 9, 2024

QichenZhu commented Dec 9, 2024

dubielzyk-expensify commented Dec 10, 2024

dubielzyk-expensify left a comment

brunovjk commented Dec 10, 2024

brunovjk Dec 10, 2024

brunovjk left a comment

QichenZhu commented Dec 11, 2024

brunovjk commented Dec 11, 2024

neil-marcellini left a comment

OSBotify commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

luacmartins commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024

Fix IOU amount input flicking #53740

Fix IOU amount input flicking #53740

Conversation

QichenZhu commented Dec 8, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 8, 2024

melvin-bot bot commented Dec 9, 2024

dubielzyk-expensify commented Dec 9, 2024

dubielzyk-expensify commented Dec 9, 2024 • edited Loading

shawnborton commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

brunovjk commented Dec 9, 2024

Reviewer Checklist

Screenshots/Videos

brunovjk commented Dec 9, 2024 • edited Loading

brunovjk commented Dec 9, 2024

QichenZhu commented Dec 9, 2024

dubielzyk-expensify commented Dec 10, 2024

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

brunovjk commented Dec 10, 2024

brunovjk Dec 10, 2024

Choose a reason for hiding this comment

brunovjk left a comment

Choose a reason for hiding this comment

QichenZhu commented Dec 11, 2024

brunovjk commented Dec 11, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

luacmartins commented Dec 12, 2024 • edited Loading

github-actions bot commented Dec 13, 2024

QichenZhu commented Dec 8, 2024 •

edited

Loading

dubielzyk-expensify commented Dec 9, 2024 •

edited

Loading

brunovjk commented Dec 9, 2024 •

edited

Loading

luacmartins commented Dec 12, 2024 •

edited

Loading