-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReportUtils.getReport method export #54113
Remove ReportUtils.getReport method export #54113
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@thesahindia kind bump! |
Reviewing |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-18.at.5.17.22.PM.movAndroid: mWeb ChromeScreen.Recording.2024-12-18.at.4.58.52.PM.moviOS: NativeScreen.Recording.2024-12-18.at.4.38.16.PM.moviOS: mWeb SafariScreen.Recording.2024-12-18.at.4.42.36.PM.movMacOS: Chrome / SafariScreen.Recording.2024-12-18.at.4.20.20.PM.movScreen.Recording.2024-12-18.at.4.18.26.PM.movMacOS: DesktopScreen.Recording.2024-12-18.at.4.23.56.PM.movScreen.Recording.2024-12-18.at.4.25.17.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The lint check is failing due to the new rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing due to a new rule, not going to fix it in this refactoring PR as it would majorly increase the changes of regressions https://github.com/Expensify/App/actions/runs/12393740088/job/34595689951?pr=54113
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explained above, not emergency |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
2 similar comments
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀
|
Explanation of Change
Remove ReportUtils.getReport method export.
More context here: #53385 (comment)
Fixed Issues
$ #53141
PROPOSAL: N/A
Tests
Copy onyx data
works as expected.7.1 Navigate to any report
7.2 Click on header > Private notes
7.3 Add markdown image to private notes:
7.4 Click on 'Private notes'
7.5 Click on image
7.6 Verify image should be opened in the attachment carousel just like any image added to Expensify Chat
Offline tests
Same, as in the Tests section.
QA Steps
Same, as in the Tests section.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android1.mp4
Android: mWeb Chrome
android_web1.mp4
android_web2.mp4
iOS: Native
ios1.mp4
iOS: mWeb Safari
ios_web1.mp4
MacOS: Chrome / Safari
web1.mp4
MacOS: Desktop
desktop1.mp4