Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Revert "Replace navigation blur listeners with useFocusEffect"" #54269

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[CP Staging] Revert "Revert "Replace navigation blur listeners with useFocusEffect"" #54269

merged 1 commit into from
Dec 17, 2024
+109 −30

Conversation

luacmartins
Copy link
Contributor

Reverts #54244

@luacmartins luacmartins self-assigned this Dec 17, 2024
@luacmartins luacmartins marked this pull request as ready for review December 17, 2024 22:02
@luacmartins luacmartins requested a review from a team as a code owner December 17, 2024 22:02
@melvin-bot melvin-bot bot requested a review from srikarparsi December 17, 2024 22:03
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 17, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 17, 2024 22:03
@luacmartins luacmartins mentioned this pull request Dec 17, 2024
Merged
48 tasks
@luacmartins luacmartins merged commit 78105ec into main Dec 17, 2024
14 of 16 checks passed
@luacmartins luacmartins deleted the revert-54244-revert-53735-53360-replace-blur-listeners-with-useFocusEffect branch December 17, 2024 22:19
@melvin-bot melvin-bot bot added the Emergency label Dec 17, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 17, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Dec 17, 2024
@luacmartins @OSBotify
Merge pull request #54269 from Expensify/revert-54244-revert-53735-53…
2df3e19 
…360-replace-blur-listeners-with-useFocusEffect

Revert "Revert "Replace navigation blur listeners with `useFocusEffect`""

(cherry picked from commit 78105ec)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 17, 2024
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Closed
60 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@luacmartins luacmartins changed the title Revert "Revert "Replace navigation blur listeners with useFocusEffect"" [CP Staging] Revert "Revert "Replace navigation blur listeners with useFocusEffect"" Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.76-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.0.76-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@srikarparsi srikarparsi Awaiting requested review from srikarparsi

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @AndrewGable