-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor User_IsFromPublicDomain in App #9759
Conversation
Looks like you modified Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands. Unsure if your change is okay? Drop a note in #expensify-open-source! |
Log.info(`Command User_IsFromPublicDomain returned error code: ${response.jsonCode}. Most likely, this means that the domain ${Str.extractEmail(sessionEmail)} is not in the bedrock cache. Retrying in ${RETRY_TIMEOUT / 1000 / 60} minutes`); | ||
setTimeout(getDomainInfo, RETRY_TIMEOUT); | ||
} | ||
DeprecatedAPI.User_IsUsingExpensifyCard() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command will be refactored in a separate PR
Putting on hold until the Web-E PR hits prod |
const commandName = 'User_IsFromPublicDomain'; | ||
requireParameters(['email'], parameters, commandName); | ||
return Network.post(commandName, { | ||
...{requireCertainty: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed this to false in the Web-E PR since all use cases in NewDot default to false in case we don't have a Clearbit response in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Expensify/Web-Expensify/pull/34247 is on prod. Removing hold and merging! |
@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Tests passed! Removing |
🚀 Deployed to staging by @luacmartins in version: 1.1.83-2 🚀
|
@luacmartins When I use expensifail account to login tester sees the email as applause.expensifail.com@expensify.cash |
@mvtglobally Seems correct to me! |
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
Details
Refactors
User_IsFromPublicDomain
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211831
Tests
isFromPublicDomain
existsUser_IsFromPublicDomain
User_IsUsingExpensifyCard
is still triggeredPR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
gmail.com
Workspace > Pay bills
Manage your bills
isexample.com@expensify.cash
private.com
5 Verify that the email under
Manage your bills
isprivate.com@expensify.cash
Screenshots
Web
web.mov
Mobile Web
Desktop
iOS
Android