-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed usage of fetchCountryCodeByRequestIP #9801
Merged
luacmartins
merged 2 commits into
main
from
techievivek_remove_usage_of_fetchCountryCodeByRequestIP
Jul 13, 2022
Merged
Removed usage of fetchCountryCodeByRequestIP #9801
luacmartins
merged 2 commits into
main
from
techievivek_remove_usage_of_fetchCountryCodeByRequestIP
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
stitesExpensify
and removed request for
a team
July 8, 2022 10:58
Will update the test today, just pushing a bunch of PRs in Web-E and App repo related to refactor. |
techievivek
changed the title
Removed usage of fetchCountryCodeByRequestIP
[HOLD WEB#34262]Removed usage of fetchCountryCodeByRequestIP
Jul 11, 2022
This is ready for the review. |
luacmartins
approved these changes
Jul 12, 2022
stitesExpensify
approved these changes
Jul 13, 2022
luacmartins
changed the title
[HOLD WEB#34262]Removed usage of fetchCountryCodeByRequestIP
Removed usage of fetchCountryCodeByRequestIP
Jul 13, 2022
https://github.com/Expensify/Web-Expensify/pull/34262 is in prod. Removing hold and merging. |
luacmartins
deleted the
techievivek_remove_usage_of_fetchCountryCodeByRequestIP
branch
July 13, 2022 17:57
95 tasks
This was referenced Jul 14, 2022
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
90 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Removed usage of
fetchCountryCodeByRequestIP
because the same has been incorporated in the App start and reconnect command.HOLD ON https://github.com/Expensify/Web-Expensify/pull/34262 DEPLOYED TO PRODUCTION
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/213884
Tests
OpenApp
now returns an additional object inonyxData
with keycountryCode
and value being the country code.Request Money
and enter the amount now in the next step enter the phone number and make sure it is prefixed with the country code.PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Same as tests.
Screenshots
Web
Mobile Web
Desktop
iOS
Android