[No QA] Change job outputs to UPPER_SNAKE_CASE #9866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
alex-mechler
and removed request for
a team
AndrewGable
requested review from
AndrewGable
and removed request for
alex-mechler
AndrewGable
approved these changes
Jul 12, 2022
|
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
Tests were passing... |
95 tasks
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We are unsure why the
createNewVersionjob is being skipped, and we're unable to reproduce the problem in the test repo.So now I'm just wanting to retry to see if it's some GitHub bug / fluke, and this PR puts this workflow inline with our existing conventions for job outputs.
Fixed Issues
$ n/a
Tests