Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Use Node 16 and NPM 8 going forward #9867

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8174b68
Use Node 16 and NPM 8
AndrewGable Jul 12, 2022
326f81d
Use npmrc file for setup-node
AndrewGable Jul 12, 2022
9d26e16
Merge branch 'main' into andrew-node-16
AndrewGable Jul 12, 2022
3d56665
Verify it uses node 16 for lint
AndrewGable Jul 13, 2022
713735b
Use `andrew-node-16` ref
AndrewGable Jul 13, 2022
481c645
Use node16 ref for all PRs
AndrewGable Jul 13, 2022
7ac4584
Merge branch 'marcaaron-remove-react-navigation-compat' into andrew-n…
AndrewGable Jul 13, 2022
5f253b9
Update `babel-plugin-react-native-web` for `@storybook/addon-react-na…
AndrewGable Jul 13, 2022
5111dc9
Update depdencies to find a working `npm install`
AndrewGable Jul 13, 2022
8a0a8db
Fix `npm ci`
AndrewGable Jul 13, 2022
940d07d
Update `react-native-onyx`
AndrewGable Jul 13, 2022
4cb7440
Install a11y plugin
AndrewGable Jul 13, 2022
9d98013
Rebuild actions
AndrewGable Jul 13, 2022
e2a3b9e
Remove flipper library as it's unused
AndrewGable Jul 13, 2022
9945f65
Fix tests
AndrewGable Jul 13, 2022
7d3f47c
Merge branch 'main' into andrew-node-16
AndrewGable Jul 13, 2022
a0998b3
Update lock
AndrewGable Jul 13, 2022
f5fb39f
Update to new ocktokit version
AndrewGable Jul 13, 2022
b7643e4
Fix actions and tests
AndrewGable Jul 13, 2022
b93ff4f
Start to fix lint
AndrewGable Jul 13, 2022
dd31c48
Fix lint
AndrewGable Jul 13, 2022
a350b6b
Update actions
AndrewGable Jul 13, 2022
f943705
Merge branch 'main' into andrew-node-16
AndrewGable Jul 13, 2022
7ccdb69
Update from main
AndrewGable Jul 13, 2022
82be029
Fix iOS depdencies
AndrewGable Jul 14, 2022
7116116
Update to react-native-web latest
AndrewGable Jul 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
module.exports = {
extends: ['expensify', 'plugin:storybook/recommended'],
parser: 'babel-eslint',
ignorePatterns: ['!.*', 'src/vendor', '.github/actions/**/index.js'],
ignorePatterns: ['!.*', 'src/vendor', '.github/actions/**/index.js', 'node_modules/.bin/**', '.git/**'],
env: {
jest: true,
},
rules: {
'react/forbid-prop-types': ['off'],
},
settings: {
'import/resolver': {
node: {
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/composite/setupNode/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:

- uses: actions/setup-node@09ba51f18e18a3756fea1f54d09c6745c064491d
with:
node-version: 14.19.3
node-version-file: '.nvmrc'
cache: npm

- name: Install node packages
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function run() {
_.throttle(
() => Promise.all([
// These are active deploys
GitHubUtils.octokit.actions.listWorkflowRuns({
GitHubUtils.octokit.rest.actions.listWorkflowRuns({
owner: GitHubUtils.GITHUB_OWNER,
repo: GitHubUtils.APP_REPO,
workflow_id: 'platformDeploy.yml',
Expand All @@ -21,7 +21,7 @@ function run() {

// These have the potential to become active deploys, so we need to wait for them to finish as well (unless we're looking for a specific tag)
// In this context, we'll refer to unresolved preDeploy workflow runs as staging deploys as well
!tag && GitHubUtils.octokit.actions.listWorkflowRuns({
!tag && GitHubUtils.octokit.rest.actions.listWorkflowRuns({
owner: GitHubUtils.GITHUB_OWNER,
repo: GitHubUtils.APP_REPO,
workflow_id: 'preDeploy.yml',
Expand Down
Loading