Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Bump Onyx lib to version 1.0.8 #9877

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Jul 13, 2022

Details

Bump Onyx lib to version 1.0.8

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/218614

Tests

Testing of the actual mergeCollection method will take place in the follow up App PR.

  • Verify that no errors appear in the JS console

Screenshots

Web

Screenshot 2022-07-13 at 11 36 20

@Julesssss Julesssss requested a review from a team as a code owner July 13, 2022 10:31
@Julesssss Julesssss self-assigned this Jul 13, 2022
@melvin-bot melvin-bot bot requested review from puneetlath and removed request for a team July 13, 2022 10:31
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mountiny mountiny merged commit b9a126b into main Jul 13, 2022
@mountiny mountiny deleted the jules-bumpOnyxVersion branch July 13, 2022 10:42
@melvin-bot melvin-bot bot added the Emergency label Jul 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2022

@mountiny looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss
Copy link
Contributor Author

Bad bot

@roryabraham roryabraham changed the title [NO-QA] Bump Onyx lib to version 1.0.8 [NO QA] Bump Onyx lib to version 1.0.8 Jul 14, 2022
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants