Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fetch tags before updating StagingDeployCash #9901

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[No QA] Fetch tags before updating StagingDeployCash #9901

merged 2 commits into from
Jul 13, 2022

Conversation

roryabraham
Copy link
Contributor

Details

I am looking at recent changes and noticed we removed this fetch-depth: 0: https://github.com/Expensify/App/pull/9812/files#diff-1219dd7a2951518446d9e9da907af2e02968bce34c2d2adda8ee4357bf22fa0cL87, which seems like a likely culprit for why our Git history would be messed up

Fixed Issues

$ n/a – broken deploys https://github.com/Expensify/App/runs/7330727826?check_suite_focus=true

Tests

  1. Merge this PR
  2. That should trigger a staging deploy and update the checklist.

@roryabraham roryabraham self-assigned this Jul 13, 2022
@roryabraham roryabraham requested a review from a team as a code owner July 13, 2022 23:36
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team July 13, 2022 23:36
francoisl
francoisl approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@francoisl francoisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing and merging as discussed in #deployers to attempt to unbreak deploys.

@francoisl francoisl merged commit 5712e1f into main Jul 13, 2022
@francoisl francoisl deleted the Rory-FixGitLog branch July 13, 2022 23:46
@OSBotify OSBotify mentioned this pull request Jul 13, 2022
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @francoisl