-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Chat - Badge "stg" is missing #9960
Conversation
@@ -11,11 +11,16 @@ function isBetaBuild() { | |||
fetch(CONST.PLAY_STORE_URL) | |||
.then(res => res.text()) | |||
.then((text) => { | |||
const productionVersionMatch = text.match(/<span[^>]+class="htlgb"[^>]*>([-\d.]+)<\/span>/); | |||
const productionVersionMatch = text.match(/\[\[\["\d+\.\d+\.\d+/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this called productVersionMatch
because we are using the text.match
method?
If so I think we should rename it. The word Match
is confusing here because it implies comparison
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about changing it to productionVersionSearch
?, the inner me can't find a good variable name 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it is kinda tricky, heh. This is fine
Changed the variable name and awaiting another review |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.86-5 🚀
|
Fixed Issues
$#9465
Tests
App/src/libs/Environment/getEnvironment/index.native.js
Lines 20 to 23 in 903ead3
App/src/libs/Environment/getEnvironment/index.js
Line 11 in 903ead3
PR Review Checklist
PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Mobile Web
Desktop
iOS
Android