Changes in quotes

[mateusbra]

Created a process to quotes like what is done with modifyTextForUrlLinks at ExpensiMark module having a function to deal with quotes:

Fixed Issues

Expensify/App#2670

Tests

1. Tested in the chat with these inputs:

> This is a one line quote

> This is a two line quote
> And this is the second line

> This is a three line quote
>
> With an empty line in the middle that has no space after the chevron

> This is another three line quote
>  
> But this time there's a space after the middle chevron

> This is another three-line quote
> 
>
>
> But this time there's a space after the middle chevron

QA

1. Type in the keyboard and see that the quote now works correctly

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[mateusbra]

I have read the CLA Document and I hereby sign the CLA

[mateusbra]

Changes were made in order to solve the tests and lints problems

[TomatoToaster]

Had just one minor change I noticed. I'm going to tag someone else for review here too.

[roryabraham]

So in addition to the changes I've outlined so far, please add several unit tests in ExpensiMark-test.js to cover your changes.

Also, I really think you should separate the matching step from the replacement step, (i.e: follow the example here).

[mateusbra]

So in addition to the changes I've outlined so far, please add several unit tests in ExpensiMark-test.js to cover your changes.

Also, I really think you should separate the matching step from the replacement step, (i.e: follow the example here).

Now the main part of quote replacement was moved to a replacement function as you said

[mateusbra]

So in addition to the changes I've outlined so far, please add several unit tests in ExpensiMark-test.js to cover your changes.

Also, I really think you should separate the matching step from the replacement step, (i.e: follow the example here).

some tests were added for verifying quotes inside codefence

[roryabraham]

FYI there are conflicts in this PR.

[mateusbra]

FYI there are conflicts in this PR.

solved

[roryabraham]

I think this is looking much better now.

[TomatoToaster]

Thanks for resolving all the changes!

[TomatoToaster]

@mateusbra, unfortunately we can't merge your PR because your commits are unsigned, for more details see here.

After setting up your commits to be signed, the simplest thing you can do is create a new branch and cherry pick the commits from this branch to there. Alternatively you can use git rebase and squish the commits to one and force push it, but I would not recommend testing that out in a seperate branch first so you don't lose your changes here.

[mateusbra]

@mateusbra, unfortunately we can't merge your PR because your commits are unsigned, for more details see here.

After setting up your commits to be signed, the simplest thing you can do is create a new branch and cherry pick the commits from this branch to there. Alternatively you can use git rebase and squish the commits to one and force push it, but I would not recommend testing that out in a seperate branch first so you don't lose your changes here.

@TomatoToaster thanks for helping me out, I had some problems with git cherry-pick (since the files were the same I couldn't make it without changing something), so I've added an apostrophe.

@TomatoToaster @roryabraham sorry for the mistake, I think you will have to approve again.

[roryabraham]

@mateusbra This is still unmergable:

Here's a resource with instructions for setting up commit signing (it's not obvious to me which commits, if any, are signed): https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits

Once you've got that working so that any new commits are automatically signed, you've got several options:

1. Create a new branch off main, and then cherry-pick the commits from this branch into that one.
2. Create a new branch off main and then manually duplicate the changes from this branch in that one.
3. Squash the commits in this branch into one signed commit and then force-push that commit to this branch. Instructions here.

[mateusbra]

@roryabraham @TomatoToaster thanks for helping me out again, and sorry for the problems.
I think now its mergable.