-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in quotes #385
Changes in quotes #385
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Changes were made in order to solve the tests and lints problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had just one minor change I noticed. I'm going to tag someone else for review here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in addition to the changes I've outlined so far, please add several unit tests in ExpensiMark-test.js to cover your changes.
Also, I really think you should separate the matching step from the replacement step, (i.e: follow the example here).
4bbf18a
to
6a93b5c
Compare
Now the main part of quote replacement was moved to a replacement function as you said |
some tests were added for verifying quotes inside codefence |
FYI there are conflicts in this PR. |
solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking much better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving all the changes!
@mateusbra, unfortunately we can't merge your PR because your commits are unsigned, for more details see here. After setting up your commits to be signed, the simplest thing you can do is create a new branch and cherry pick the commits from this branch to there. Alternatively you can use |
1aff60e
@TomatoToaster thanks for helping me out, I had some problems with git cherry-pick (since the files were the same I couldn't make it without changing something), so I've added an apostrophe. @TomatoToaster @roryabraham sorry for the mistake, I think you will have to approve again. |
@mateusbra This is still unmergable: Here's a resource with instructions for setting up commit signing (it's not obvious to me which commits, if any, are signed): https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits Once you've got that working so that any new commits are automatically signed, you've got several options:
|
1aff60e
to
cc051a3
Compare
cc051a3
to
5ed6ab8
Compare
@roryabraham @TomatoToaster thanks for helping me out again, and sorry for the problems. |
Created a process to quotes like what is done with
modifyTextForUrlLinks
at ExpensiMark module having a function to deal with quotes:Fixed Issues
Expensify/App#2670
Tests
QA
Tested On
Screenshots
Android