-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/21846 heading after quote is not rendering #557
Fix/21846 heading after quote is not rendering #557
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@s77rt Can you please have a look why |
recheck |
@spcheema The CLA seems okay #557 (comment). Don't orry about the workflow, it will be triggered later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
@aldo-expensify Can you help to merge this PR if you're also happy with the change? |
The changes LGTM @cead22 do you want to have a look here before I merge? I think you may have more context. |
Thanks @aldo-expensify |
Fixed Issues
$ #21846
PROPOSAL: #21846 (comment)
Tests
Following cases are verified while performing unit test:
QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Heading.after.quote.-.web.mp4
Mobile Web - Chrome
Heading.quote.-.Android.web.mp4
Mobile Web - Safari
Heading.quote.-.ios.web.mp4
Desktop
heading.after.quote.-.desktop.mp4
iOS
heading.after.quote.-.ios.app.mp4
Android
heading.after.quote.android.mp4