Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emoji rule #664

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Add emoji rule #664

merged 1 commit into from
Mar 21, 2024

Conversation

dukenv0307
Copy link
Contributor

Fixed Issues

$ Expensify/App#34307

Tests

  1. Open any chat
  2. Send a message with emoji
  3. See the html of the message and verify that the emoji is wrapped in a emoji tag

QA

  1. Open any chat
  2. Send a message with emoji
  3. See the html of the message and verify that the emoji is wrapped in a emoji tag

Offline test

Same as above

Screenshots/Videos

Android: Native
Android: mWeb Chrome Screenshot 2024-01-24 at 15 06 48
iOS: Native
iOS: mWeb Safari Screenshot 2024-01-24 at 15 05 31
MacOS: Chrome / Safari Screenshot 2024-01-24 at 15 02 03
MacOS: Desktop Screenshot 2024-01-24 at 15 09 11

@dukenv0307 dukenv0307 marked this pull request as ready for review March 13, 2024 09:27
@dukenv0307 dukenv0307 requested a review from a team as a code owner March 13, 2024 09:27
@melvin-bot melvin-bot bot requested review from Beamanator and removed request for a team March 13, 2024 09:28
@dukenv0307 dukenv0307 mentioned this pull request Mar 13, 2024
Closed
@situchan
Copy link
Contributor

situchan commented Mar 13, 2024 •
edited
Loading

Please don't merge this PR and for testing, point app PR to the commit hash of this branch.
This PR should be merged at the exact moment when app PR will be merged.

@Beamanator Beamanator requested review from stitesExpensify and removed request for Beamanator March 13, 2024 10:16
@Beamanator
Copy link
Contributor

@stitesExpensify assigning you since you're assigned to the issue

@stitesExpensify
Copy link
Contributor

Thanks!

@dukenv0307 dukenv0307 mentioned this pull request Mar 18, 2024
Merged
50 tasks
@stitesExpensify stitesExpensify merged commit 4e020cf into Expensify:main Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dukenv0307 @situchan @Beamanator @stitesExpensify