Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update contentSelection ref after text change #370

Merged

Conversation

dominictb
Copy link
Contributor

@dominictb dominictb commented Jun 7, 2024

Details

Expensify/App#41137 (comment)

Related Issues

Expensify/App#41137

Manual Tests

Tested on Firefox

Screen.Recording.2024-06-07.at.14.48.34.mov

Linked PRs

Expensify/App#42622

Signed-off-by: dominictb <tb-dominic@outlook.com>
@dominictb
Copy link
Contributor Author

@BartoszGrajdek to review here

@BartoszGrajdek
Copy link
Collaborator

Testing!

Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixed the bug 👍🏻

@BartoszGrajdek BartoszGrajdek merged commit b857713 into Expensify:main Jun 7, 2024
4 checks passed
@BartoszGrajdek
Copy link
Collaborator

Thank you for a quick reaction @dominictb 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants