fix(web)[TextInput]: cursor jumps to the start when secureTextEntry i…

[pac-guerreiro]

This PR fixes Expensify/App#21727

Problem

On web, the cursor jumps to the start of the input when secureTextEntry is toggled.

Solution

Preserve and restore previous selection after secureTextEntry is toggled.

The proposal and demo are available in this comment: Expensify/App#21727 (comment)

[sobitneupane]

@pac-guerreiro In IOS/Safari, I am having following issue

Screen.Recording.2023-08-01.at.18.24.32.mov

[pac-guerreiro]

Uploading Screen Recording 2023-08-01 at 18.46.43.mov…

@sobitneupane

You sure you're running my code? I just tested my changes on iOS/safari and they work 😅

[sobitneupane]

@pac-guerreiro Looks like the screen recording didn't get uploaded in previous message

[pac-guerreiro]

@sobitneupane

My bad 😅

Screen.Recording.2023-08-01.at.18.46.43.mov

[sobitneupane]

Thanks @pac-guerreiro.

We are good to merge this.

cc: @NikkiWines

[NikkiWines]

Looks like there are some formatting and unit test errors

[pac-guerreiro]

@NikkiWines

My bad 😅 I just pushed fixes for those issues!

[NikkiWines]

No worries @pac-guerreiro - looks like there's still one failure

[pac-guerreiro]

@NikkiWines second time's the charm 😅

[NikkiWines]

[roryabraham]

Hello everyone 👋🏼 few PSA's here:

• Generally we should not review or merge any PRs in any of our forked dependencies if there is not an equivalent PR in the upstream. Same goes for any PR that introduces a patch file
• I think we are going to stop using this fork and move to patch files instead for all the same reasons we ditched the react-native fork. This repo is easier to build and publish, but still it's an extra step we don't want to deal with and we invested in an awesome new feature in patch-package that allows us to have multiple patch files for a single dependency applied in sequence.

So in conclusion, I think we need to:

• create an issue in the upstream react-native-web repo with a minimal reproduction of the bug
• create an upstream PR in the react-native-web repo for this change
• Only once that's completed and we have an upstream PR to reference should we proceed with this code in a patch file in E/App instead of in this fork
• To prevent any duplicate work, we should wait until [$3500] Upgrade to react-native-web v0.19.6 or greater App#16660 is complete before introducing the new patch including this code