-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make map bound calculations simpler #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayata-suenaga
changed the title
fix: issues with bounds calculations
Make map bound calculations simpler
Aug 21, 2023
57 tasks
@allroundexperts I added you as a reviewer of this PR as you're also reviewing this related PR. |
57 tasks
flodnv
approved these changes
Aug 21, 2023
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
I gonna go ahead and merge this even though checklist is not filled, it's not relevant to this repo so much |
Version InfoThis PR bumped the version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @neil-marcellini @thienlnam
Terminology
Map
: A component fromreact-map-gl
thatreact-native-x-maps
uses under the hood for web code.MapView
: A component thatreact-native-x-maps
implements and is used by NewDot.Details
This PR not the exposed API of
MapView
. This PR fixes an issue that was present with previous version of the code.Use a simpler API from
react-map-gl
andmapbox-gl
to pan the map in order to fit all waypoints within the visible area. ThefitBounds
method on the map instance is called to pan the map. The map instance is returned by invokinggetMap
method onMap
.The previous code stored the ref to
Map
withuseRef
. However, I realized thatmapRef
is sometimes not set when thegetMap
method is invoked on it. So, instead of usinguseRef
, I decided to useuseState
and the callback ref to store the reference toMap
.In the
useEffect
where I pan the map, I addedmapRef
as a dependency. BecausemapRef
is a state, ifmapRef
's value changes (i.e.null
-> reference toMap
), theMapView
re-renders, triggeringuseEffect
and panning the map if conditions are met.Related Issues
GH_LINK Expensify/App#22706
Manual Tests
This PR is tested in this App PR. This test branch/PR in react-native-x-maps is used for testing in the App PR. The test branch is a clone of this PR but it also includes the transpiled code. If the test branch works in App, that means this PR is good to go. If this PR is merged, the code is transpiled in CI and a new version of npm package is published.
Linked PRs
Expensify/App#25161