Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade serialport to 10.4.0 #296

Merged
merged 1 commit into from
Mar 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
"@types/react-router-dom": "^5.1.7",
"@types/react-test-renderer": "^17.0.1",
"@types/rimraf": "^3.0.0",
"@types/serialport": "^8.0.1",
"@types/serialport": "^8.0.2",
"@types/uuid": "^8.3.0",
"@types/webpack-env": "^1.16.0",
"@typescript-eslint/eslint-plugin": "^5.10.0",
Expand Down
5 changes: 3 additions & 2 deletions src/api/src/services/SerialMonitor/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Service } from 'typedi';
import SerialPort from 'serialport';
import { SerialPort } from 'serialport';
import { PubSubEngine } from 'graphql-subscriptions';
import SerialPortInformation from '../../models/SerialPortInformation';
import PubSubTopic from '../../pubsub/enum/PubSubTopic';
Expand Down Expand Up @@ -55,7 +55,8 @@ export default class SerialMonitorService {
await this.disconnect();
}

this.port = new SerialPort(device, {
this.port = new SerialPort({
path: device,
baudRate,
autoOpen: false,
});
Expand Down
2 changes: 1 addition & 1 deletion src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
},
"license": "GPL-3.0-or-later",
"dependencies": {
"serialport": "9.2.8"
"serialport": "^10.4.0"
}
}
Loading