Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage report generation for the top-level project #486

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

rdumusc
Copy link

@rdumusc rdumusc commented Apr 22, 2016

No description provided.

@@ -1,5 +1,7 @@
# git master

* [486](https://github.com/Eyescale/CMake/pull/486):
Fix coverage report generation for non-subprojects

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, you have solved it for the subproject case. Don't you mean "for non-superprojects"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from Daniel's commit but it is correct. It was already working for the subproject case (i.e. a project which is a subproject of viz/stable for instance). Now it is fixed (with a small limitation) for projects which are not a subproject but are their own superproject (thus non-subprojects). Nomenclature is a bit tricky for sure :-)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to agree on the nomenclature, because what you call the subproject case (viz/stable) for me it's the superproject case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or: fix coverage report generation for the top-level project?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that one.

@rdumusc rdumusc changed the title Fix coverage report generation for non-subprojects Fix coverage report generation for the top-level project Apr 26, 2016
@rdumusc
Copy link
Author

rdumusc commented Apr 26, 2016

updated

@hernando
Copy link

+1

@rdumusc rdumusc merged commit 5b8d588 into Eyescale:master Apr 26, 2016
@rdumusc rdumusc deleted the coverage branch April 26, 2016 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants