-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage report generation for the top-level project #486
Conversation
@@ -1,5 +1,7 @@ | |||
# git master | |||
|
|||
* [486](https://github.com/Eyescale/CMake/pull/486): | |||
Fix coverage report generation for non-subprojects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, you have solved it for the subproject case. Don't you mean "for non-superprojects"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from Daniel's commit but it is correct. It was already working for the subproject case (i.e. a project which is a subproject of viz/stable for instance). Now it is fixed (with a small limitation) for projects which are not a subproject but are their own superproject (thus non-subprojects). Nomenclature is a bit tricky for sure :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to agree on the nomenclature, because what you call the subproject case (viz/stable) for me it's the superproject case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or: fix coverage report generation for the top-level project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer that one.
updated |
+1 |
No description provided.