Improvements in the package installation feature. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait a moment. This code is leaving __pkg_mng set and it appears in the ccmake menu. |
| find_program(__pkg_mng apt-get) | ||
| if(__pkg_mng) | ||
| set(__pkg_type DEB) | ||
| elseif(__pkg_mng) |
hernando
force-pushed
the
master
branch
2 times, most recently
from
b003f78
to
1057744
Compare
| find_program(__pkg_mng apt-get) | ||
| if(__pkg_mng) | ||
| set(__pkg_type DEB) | ||
| else(__pkg_mng) |
There was a problem hiding this comment.
please don't repeat the condition in the else()
|
looks good otherwise |
hernando
force-pushed
the
master
branch
2 times, most recently
from
03f69ec
to
786de86
Compare
| # "port install" the known system packages. Will be unset after installation. | ||
| # - INSTALL_PACKAGES: command line cache variable which will "apt-get", "yum" or | ||
| # "port install" the known system packages. This variable is unset from | ||
| # common_find_package_post. |
Support for yum. Avoid caching of INSTALL_PACKAGES in CMakeCache.txt (this behaviour was documented but not implemented). Improved documentation. This changes are motivated by some issues reported by a user trying to compile Equalizer in RHEL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for yum and avoid caching of INSTALL_PACKAGES in CMakeCache.txt.
This changes are motivated by some issues reported by a user trying
to compile Equalizer in RHEL.