Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Optional uri paramenter was required for ext-x-media #43

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: Optional uri paramenter was required for ext-x-media #43

merged 1 commit into from
Sep 25, 2023
+6 −1

Conversation

VolcanoCookies
Copy link
Contributor

@VolcanoCookies VolcanoCookies commented Sep 25, 2023 •
edited
Loading

URI is only required when the type is SUBTITLES, otherwise it is optional.

Fixes #42

@VolcanoCookies VolcanoCookies added the bug Something isn't working label Sep 25, 2023
birme
birme approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme birme merged commit 3c8a63c into main Sep 25, 2023
5 checks passed
@birme birme deleted the fix/optional-uri-property branch September 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'match') with HLS
2 participants
@VolcanoCookies @birme