Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list on launch page doesnt display last items #183

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

malmen237
Copy link
Contributor

List is currently displayed wrong and only returns the 10 oldest productions. This is probably due to a re-arrange of the results in handleFetchRequest or somewhere else along the fetch-line.

Added a sorting that guarantees that the sorting always will arrange the production-id from highest to lowest, to make sure that the last added productions will be displayed.

@malmen237 malmen237 added the bug Something isn't working label Jul 8, 2024
@malmen237 malmen237 requested review from martinstark and birme July 8, 2024 10:13
Copy link
Collaborator

@martinstark martinstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, still digging into if the manager updated the order of its returned items, or if this bug has always existed

@martinstark martinstark merged commit f4a3b3e into main Jul 8, 2024
2 checks passed
@martinstark martinstark deleted the fix/list-on-launch-page-doesnt-display-last-items branch July 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants