Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api modelling base #1

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: api modelling base #1

merged 1 commit into from
Nov 8, 2023

Conversation

oshinongit
Copy link
Contributor

@oshinongit oshinongit commented Nov 7, 2023

Base models for the request and response bodies needed to create smb conferences and endpoints. Some suggestions on basic rest api calls that can be and the corresponding instances that are created.

Going forward we can perhaps implement the functions to be named in accordance with intercom and svt produktion conventions.

Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes requested. You can merge afterwards

src/api_productions.ts Outdated Show resolved Hide resolved
src/models.ts Outdated Show resolved Hide resolved
@oshinongit oshinongit merged commit 76b1d24 into main Nov 8, 2023
4 checks passed
@oshinongit oshinongit deleted the base-api branch November 8, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants